What's your idea?
I was setting up the book drop and was surprised to find that the way that the BOOK_DROP_HOST_PATH env var works is that it doesn't change the container mount. In other words, you always have to map the book drop directory to /data/book-dock.
The way this should work instead is that if you set the environment variable, it makes that directory the bookdrop directory.
What problem does it solve?
Doing it thew ay above allows for if you have /books/library (where your library is) and /books/bookdrop (where you want books to be looked for by bookorbit) you only have to do one volume mount, so that Docker/k8s sees it as a unified filesystem vs. separate volumes.
Anything else? (optional)
This would at least potentially break previous installs for people who set that env var and mapped to the existing /data/book-dock directory. It's just basically an unnecessary env var otherwise.
Want to help?
Just sharing the idea
Before submitting
What's your idea?
I was setting up the book drop and was surprised to find that the way that the BOOK_DROP_HOST_PATH env var works is that it doesn't change the container mount. In other words, you always have to map the book drop directory to
/data/book-dock.The way this should work instead is that if you set the environment variable, it makes that directory the bookdrop directory.
What problem does it solve?
Doing it thew ay above allows for if you have /books/library (where your library is) and /books/bookdrop (where you want books to be looked for by bookorbit) you only have to do one volume mount, so that Docker/k8s sees it as a unified filesystem vs. separate volumes.
Anything else? (optional)
This would at least potentially break previous installs for people who set that env var and mapped to the existing /data/book-dock directory. It's just basically an unnecessary env var otherwise.
Want to help?
Just sharing the idea
Before submitting