fix: uv_tty_init error on Windows#235
Merged
natemoo-re merged 1 commit intobombshell-dev:mainfrom Mar 21, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 17a011c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@sapphi-red Thanks so much! I am trying out clack for the first time on Windows, using the built-in Git Bash for Windows that comes automatically when you install Git, and I was confronted with this error. Here's hoping we can get this merged soon with a new release! |
bluwy
added a commit
to vitejs/vite
that referenced
this pull request
Feb 25, 2025
natemoo-re
approved these changes
Mar 21, 2025
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Thanks so much for the fix!
natemoo-re
pushed a commit
that referenced
this pull request
Mar 30, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error happening on Windows for non-tty terminals.
The error was happening this line.
clack/packages/core/src/prompts/prompt.ts
Line 136 in d6d9ce7
It seems calling
new tty.WriteStreamwith non-tty file descriptor throws the error above.I changed
tty.WriteStreamwithstream.Writableand setterminal: trueoption forreadline.createInterfaceso that readline will treatstream.Writableas a terminal.I first went with replacing
new WriteStream(0)withisatty(0) ? new WriteStream(0) : fs.createWriteStream(null, { fd: 0 }). It worked locally, but that didn't pass the tests.refs #192