Only allow fractional numbers in the lowest order component#11
Merged
Only allow fractional numbers in the lowest order component#11
Conversation
They are due to the fact that types for arrow are now present. We now make the int -> Decimal conversion in parse_datetime_duration() explicitly.
It is required for full conformance to ISO/DIS 8601-1.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 14 +1
Lines 300 338 +38
Branches 44 52 +8
=========================================
+ Hits 300 338 +38
Continue to review full report at Codecov.
|
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
In the process, make it iterable; a nice side effect is that it's now trivial to create a dictionary from a Duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for full conformance to ISO/DIS 8601-1, as per section 4.4.3.2, "Format with designators".