all: update shebangs for more portability

euank · josharian · commit aabca2e90134 · 2025-07-30T09:57:11.000-07:00
NixOS by default doesn't ship with /bin/bash, rather /usr/bin/env bash is the way to get the right bash.

This caused two issues on NixOS:

1. The `push` button on the web interface would fail with ` ! [remote rejected] &lt;commit&gt; -&gt; &lt;branch&gt; (pre-receive hook declined)`
2. `make` would result in an error

On the host side, for 1 you could see `fatal: cannot exec '/tmp/sketch-git-hooks-3993344797/pre-receive': No such file or directory`, and for 2, you could similarly see `make: ./build/webui.sh: No such file or directory`

This fixes both of those errors by updating to more portable shebangs.
```
diff --git a/bin/run-formatters.sh b/bin/run-formatters.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 # Script to run formatters for both Go and webui files
diff --git a/build/clean.sh b/build/clean.sh
@@ -1,6 +1,6 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 rm -f sketch
 rm -rf embedded/sketch-linux embedded/webui-dist
-rm -rf webui/node_modules webui/dist
+rm -rf webui/node_modules webui/dist
diff --git a/build/innie.sh b/build/innie.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="${LDFLAGS:-}" -tags=innie -o embedded/sketch-linux/sketch-linux-amd64 ./cmd/sketch &
diff --git a/build/outie.sh b/build/outie.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 # Note: This incantation is duplicated in .goreleaser.yml; please keep them in sync.
diff --git a/build/webui.sh b/build/webui.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 # Use a content-based hash of the webui dir to avoid unnecessary rebuilds.
diff --git a/claudetool/codereview/update_tests.sh b/claudetool/codereview/update_tests.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 CURRENT_DIR=$(pwd)
diff --git a/dockerimg/githttp_test.go b/dockerimg/githttp_test.go
@@ -51,7 +51,7 @@ func TestSetupHooksDir(t *testing.T) {
 	// Check for key elements in the script
 	contentStr := string(content)
 	if !containsAll(contentStr, []string{
-		"#!/bin/bash",
+		"#!/usr/bin/env bash",
 		"refs/remotes/origin/",
 		"git push origin",
 		"Force pushes are not allowed",
@@ -110,7 +110,7 @@ func TestPreReceiveHookScript(t *testing.T) {
 
 	// Verify the script contains the expected bash shebang
 	scriptContent := string(script)
-	if !contains(scriptContent, "#!/bin/bash") {
+	if !contains(scriptContent, "#!/usr/bin/env bash") {
 		t.Errorf("pre-receive hook missing bash shebang")
 	}
 
diff --git a/dockerimg/post-receive.sh b/dockerimg/post-receive.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Post-receive hook for sketch git http server
 # Sets upstream tracking branch for sketch branches
 
diff --git a/dockerimg/pre-receive.sh b/dockerimg/pre-receive.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Pre-receive hook for sketch git http server
 # Handles refs/remotes/origin/Y pushes by forwarding them to origin/Y
 
diff --git a/loop/update_tests.sh b/loop/update_tests.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 CURRENT_DIR=$(pwd)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-#!/bin/bash`
	`1`	`+#!/usr/bin/env bash`
`2`	`2`	`set -e`
`3`	`3`
`4`	`4`	`# Script to run formatters for both Go and webui files`