Repository navigation
[BSE-4557] Upgrade to Arrow 19 - #240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (66.91%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 61.48% 66.91% +5.42%
==========================================
Files 169 176 +7
Lines 61920 62693 +773
Branches 8663 8759 +96
==========================================
+ Hits 38070 41948 +3878
+ Misses 21430 18135 -3295
- Partials 2420 2610 +190 |
|
Can we go to 19.0.1? The fixes may be useful: https://arrow.apache.org/release/19.0.1.html |
|
@ehsantn Sure, but since I already have the fork and everything built, I wanted to get this in first |
|
Ok, sounds good. |
|
|
||
|
|
||
| class S3TablesCatalog(MetastoreCatalog): | ||
| @staticmethod |
There was a problem hiding this comment.
Looks like there are merge conflicts with the PyIceberg PR.
There was a problem hiding this comment.
Yeah I think its because of addressing some comments? I'm rebasing this PR on main now that PyIceberg is merged
scott-routledge2
left a comment
scott-routledge2
left a comment
There was a problem hiding this comment.
LGTM, thanks @srilman !
Changes included in this PR
Upgrade to Arrow 19.
Testing strategy
User facing changes
Ideally none.
Checklist
[run CI]in your commit message.