forked from v8/v8
-
Notifications
You must be signed in to change notification settings - Fork 0
Import tests from Google V8 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jugglinmike
wants to merge
1
commit into
master
Choose a base branch
from
first-v8-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are derived from the following files within the Google V8 project: test/mjsunit/es6/string-html.js
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…set #2 id:20001 of https://codereview.chromium.org/934173004/) Reason for revert: Breakage Original issue's description: > Remove handle wrappers from basic elements accessors > > BUG= > [email protected] > > Committed: https://crrev.com/40b7c513c696f405af0ae3e74e844d3c341bc3f2 > Cr-Commit-Position: refs/heads/master@{#26736} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/932693003 Cr-Commit-Position: refs/heads/master@{#26737}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
id:20001 of https://codereview.chromium.org/916543004/) Reason for revert: Tanks some benchmarks (for no obvious reason) Original issue's description: > [x64] Generate test reg,reg instead of cmp reg,0. > > The instruction sequence is shorter and saves decoding bandwidth. > > [email protected] > > Committed: https://crrev.com/a7fb5ed400701b22c455d0ad410bc98b211e5730 > Cr-Commit-Position: refs/heads/master@{#26734} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/939923003 Cr-Commit-Position: refs/heads/master@{#26742}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…set #2 id:20001 of https://codereview.chromium.org/944803002/) Reason for revert: Breaks dbg builds. Original issue's description: > [turbofan] Finally get rid of the generic algorithm. > > [email protected] > > Committed: https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9 > Cr-Commit-Position: refs/heads/master@{#26760} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/941963003 Cr-Commit-Position: refs/heads/master@{#26763}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
#2 id:20001 of https://codereview.chromium.org/928193002/) Reason for revert: See crbug.com/460412 and crbug.com/460356. Reverting on master in order to roll from master again soon. Original issue's description: > Correctly propagate terminate exception in TryCall. > > BUG=v8:3892 > LOG=Y > > Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f > Cr-Commit-Position: refs/heads/master@{#26685} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3892 Review URL: https://codereview.chromium.org/946973004 Cr-Commit-Position: refs/heads/master@{#26792}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…id:20001 of https://codereview.chromium.org/957673004/) Reason for revert: Doesn't compile Original issue's description: > Rebase GDBJIT interface solely on JITCodeEvent > > [email protected] > BUG= > > Committed: https://chromium.googlesource.com/v8/v8/+/8989d828e86bc7edae5e25687bcb60c0e301dffb [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/954833004 Cr-Commit-Position: refs/heads/master@{#26848}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…ttps://codereview.chromium.org/980173003/) Reason for revert: breaks arm compile Original issue's description: > rename UniquePersistent to Global > > BUG= > > Committed: https://crrev.com/3f5ae16c62b031ad572f750d81ffc71c5d6d1f9b > Cr-Commit-Position: refs/heads/master@{#27011} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/983653002 Cr-Commit-Position: refs/heads/master@{#27012}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…chset #2 id:20001 of https://codereview.chromium.org/1029323003/) Reason for revert: This seems to cause lots of crashes in layout tests debug: ../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp(67) : void blink::useCounterCallback(v8::Isolate *, v8::Isolate::UseCounte http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2332 Original issue's description: > Track how many pages trigger fallback strategies in GC > > [email protected] > BUG= > > Committed: https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb > Cr-Commit-Position: refs/heads/master@{#27421} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1000523003 Cr-Commit-Position: refs/heads/master@{#27427}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2015
… marking." (patchset #2 id:2 of https://codereview.chromium.org/1032833002/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Reland "Filter invalid slots out from the SlotsBuffer after marking." > > > There are two reasons that could cause invalid slots appearance in SlotsBuffer: > > 1) If GC trims "tail" of an array for which it has already recorded a slots and then migrate another object to the "tail". > > 2) Tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > > > This CL also adds useful machinery that helps triggering incremental write barriers. > > > BUG=chromium:454297 > > LOG=Y > > NOTRY=true > > Committed: https://crrev.com/f86aadd1d45c756467dff8e08a055b462d7a060b > Cr-Commit-Position: refs/heads/master@{#27433} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1041593002 Cr-Commit-Position: refs/heads/master@{#27491}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 3, 2015
…set #2 id:20001 of https://codereview.chromium.org/977013003/) Reason for revert: Spike in OOM crashes: crbug.com/403113 Original issue's description: > Remove promotion backup case and report OOM instead. > > There are no test cases for this piece of code and it is really hard to test. If this rare case triggers, we are anyway in an OOM situation and would crash probably soon afterwards. > > BUG= > > Committed: https://crrev.com/e813afaf127ab80290153ab676dc07212bdc8946 > Cr-Commit-Position: refs/heads/master@{#27026} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1050113002 Cr-Commit-Position: refs/heads/master@{#27568}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…l variables"" (patchset #2 id:20001 of https://codereview.chromium.org/1136883006/) Reason for revert: Something is deserializing "this" declarations as Variable::NORMAL and not Variable::THIS https://codereview.chromium.org/1136123010/ Original issue's description: > Reapply "Resolve references to "this" the same way as normal variables"" > > This reapplies https://codereview.chromium.org/1136073002, along with > the followups: > > Remove Scope::scope_uses_this_ flag > https://codereview.chromium.org/1128963005 > > and > > PPC: Resolve references to "this" the same way as normal variables > https://codereview.chromium.org/1134073003 > > [email protected], [email protected] > LOG=N > BUG= > > Committed: https://crrev.com/1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099 > Cr-Commit-Position: refs/heads/master@{#28458} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1146733002 Cr-Commit-Position: refs/heads/master@{#28473}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…duceRight} (patchset #2 id:20001 of https://codereview.chromium.org/1139663005/) Reason for revert: [Sheriff] Breaks win nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6872 Original issue's description: > Implement %TypedArray%.prototype.{map,filter,some,reduce,reduceRight} > > This patch adds implementations for additional TypedArray methods > from the ES6 spec, together with tests adapted from array code. > > [email protected] > BUG=v8:3578 > LOG=Y > > Committed: https://crrev.com/59ef8c5f3282f01b5990b3a46a2a3a829b699a13 > Cr-Commit-Position: refs/heads/master@{#28488} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Review URL: https://codereview.chromium.org/1143833002 Cr-Commit-Position: refs/heads/master@{#28489}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
(patchset v8#4 id:60001 of https://codereview.chromium.org/1134333005/)" This reverts commit 81c080e. Patchset #1 is the original CL. Patchset #2 fixes a handlification bug that caused the crash. [email protected] BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1143813002 Cr-Commit-Position: refs/heads/master@{#28497}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…GC happend recently. (patchset #2 id:20001 of https://codereview.chromium.org/1143113002/) Reason for revert: [Sheriff] MSAN not happy: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2352 Original issue's description: > Set lower allocation limit in idle notification only if no GC happend recently. > > BUG=475674 > LOG=n > > Committed: https://crrev.com/35e3489e8f70c7ad5973324ad3cfa4ab27059ab4 > Cr-Commit-Position: refs/heads/master@{#28506} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475674 Review URL: https://codereview.chromium.org/1145113003 Cr-Commit-Position: refs/heads/master@{#28511}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…id:20001 of https://codereview.chromium.org/1143993003/) Reason for revert: Breaks nosnap bots Original issue's description: > Use shared container to manage imports/exports. > > Also changed string.js and math.js to adapt this change. > > [email protected] > > Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd > Cr-Commit-Position: refs/heads/master@{#28521} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1144163002 Cr-Commit-Position: refs/heads/master@{#28523}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…01 of https://codereview.chromium.org/1154483002/) Reason for revert: [Sheriff] Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/6943 Original issue's description: > Hook up more import/exports in natives. > > [email protected] > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > Cr-Commit-Position: refs/heads/master@{#28573} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1154793003 Cr-Commit-Position: refs/heads/master@{#28574}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…ell. (patchset #2 id:20001 of https://codereview.chromium.org/1163073002/) Reason for revert: GC stress failures. Original issue's description: > Replace ad-hoc weakness in prototype transitions with WeakCell. > > BUG= > > Committed: https://crrev.com/bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3 > Cr-Commit-Position: refs/heads/master@{#28830} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1169733002 Cr-Commit-Position: refs/heads/master@{#28832}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…//codereview.chromium.org/1169853002/) Reason for revert: [Sheriff] fails messages: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/1703 Original issue's description: > [es6] Parsing of new.target > > BUG=v8:3887 > LOG=N > [email protected], [email protected] > > Committed: https://crrev.com/ae06bdde7763d673b39948b710df414217265cce > Cr-Commit-Position: refs/heads/master@{#28865} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3887 Review URL: https://codereview.chromium.org/1170263002 Cr-Commit-Position: refs/heads/master@{#28868}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…ttps://codereview.chromium.org/1170263002/) Reason for revert: The bot needs to be clobbered. Original issue's description: > Revert of [es6] Parsing of new.target (patchset #2 id:20001 of https://codereview.chromium.org/1169853002/) > > Reason for revert: > [Sheriff] fails messages: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/1703 > > Original issue's description: > > [es6] Parsing of new.target > > > > BUG=v8:3887 > > LOG=N > > [email protected], [email protected] > > > > Committed: https://crrev.com/ae06bdde7763d673b39948b710df414217265cce > > Cr-Commit-Position: refs/heads/master@{#28865} > > [email protected],[email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3887 > > Committed: https://crrev.com/fe97cfccf3faabbeff87b9b5fbacd7ceb8219304 > Cr-Commit-Position: refs/heads/master@{#28868} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3887 Review URL: https://codereview.chromium.org/1168393008 Cr-Commit-Position: refs/heads/master@{#28870}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…002 (patchset #2 id:20001 of https://codereview.chromium.org/1174713002/) Reason for revert: Tree looks like a Christmas tree and this isn't helping Original issue's description: > Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 > > Original code review: https://codereview.chromium.org/1176453002/ > > [email protected] > BUG=chromium:482998 > LOG=n > > Committed: https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d > Cr-Commit-Position: refs/heads/master@{#28884} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:482998 Review URL: https://codereview.chromium.org/1172893002 Cr-Commit-Position: refs/heads/master@{#28885}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…ctions. (patchset #2 id:20001 of https://codereview.chromium.org/1175953002/) Reason for revert: Breaks Windows debug. Original issue's description: > [turbofan] Record the SharedFunctionInfo of ALL inlined functions. > > Previously we only recorded the SharedFunctionInfo of inlined functions > that had at least one (lazy) deopt point left at code generation time. > > [email protected] > > Committed: https://chromium.googlesource.com/v8/v8/+/ffa0b4007cd7de0cfd6d37079ef360e3beeb5686 [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1178683004 Cr-Commit-Position: refs/heads/master@{#28920}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
… of https://codereview.chromium.org/1178673003/) Reason for revert: Blocks reverting of https://codereview.chromium.org/1175973002 Original issue's description: > Use the LookupIterator in SetAccessor > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > Cr-Commit-Position: refs/heads/master@{#28955} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1175323004 Cr-Commit-Position: refs/heads/master@{#28956}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) Reason for revert: It broke webkit_unit_tests Original issue's description: > Remove GetAttributes from the mix to avoid another virtual dispatch. > > BUG=chromium:495949,v8:4137 > LOG=n > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > Cr-Commit-Position: refs/heads/master@{#28953} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1179933002 Cr-Commit-Position: refs/heads/master@{#28958}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…r virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/) Reason for revert: Reland, this didn't break anything. Original issue's description: > Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) > > Reason for revert: > It broke webkit_unit_tests > > Original issue's description: > > Remove GetAttributes from the mix to avoid another virtual dispatch. > > > > BUG=chromium:495949,v8:4137 > > LOG=n > > > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > > Cr-Commit-Position: refs/heads/master@{#28953} > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:495949,v8:4137 > > Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 > Cr-Commit-Position: refs/heads/master@{#28958} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1182603002 Cr-Commit-Position: refs/heads/master@{#28966}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…ttps://codereview.chromium.org/1175323004/) Reason: Didn't break anything Original issue's description: > Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) > > Reason for revert: > Blocks reverting of https://codereview.chromium.org/1175973002 > > Original issue's description: > > Use the LookupIterator in SetAccessor > > > > BUG=v8:4137 > > LOG=n > > > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > > Cr-Commit-Position: refs/heads/master@{#28955} > > [email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4137 > > Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f > Cr-Commit-Position: refs/heads/master@{#28956} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181813002 Cr-Commit-Position: refs/heads/master@{#28967}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…chset #2 id:20001 of https://codereview.chromium.org/1173333004/) Reason for revert: nosnap failure Original issue's description: > Add script context with context-allocated "const this" > > This is a reapplication of https://codereview.chromium.org/1179893002/. > > [email protected],[email protected] > LOG=N > BUG=498811 > > Committed: https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968 > Cr-Commit-Position: refs/heads/master@{#28994} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498811 Review URL: https://codereview.chromium.org/1177903004 Cr-Commit-Position: refs/heads/master@{#28996}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/) Reason for revert: Still broken Original issue's description: > Reland "Keep track of array buffers in new space separately" > > Original review https://codereview.chromium.org/1133773002/ > > BUG=v8:3996 > [email protected] > LOG=n > > Committed: https://crrev.com/89b9a2cfb317e52186f682c91502b22932d52db3 > Cr-Commit-Position: refs/heads/master@{#28987} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1186613007 Cr-Commit-Position: refs/heads/master@{#29009}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
… (patchset #2 id:20001 of https://codereview.chromium.org/1185703002/) Reason for revert: [Sheriff] Makes mjsunit/es6/block-const-assign flaky, e.g.: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/4082 Original issue's description: > Fix clobbered register when setting this_function variable. > > [email protected] > TEST=mjsunit/regress/regress-crbug-498022 > BUG=chromium:498022 > LOG=N > > Committed: https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91 > Cr-Commit-Position: refs/heads/master@{#29020} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:498022 Review URL: https://codereview.chromium.org/1184093003 Cr-Commit-Position: refs/heads/master@{#29022}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…odereview.chromium.org/1177123002/) Reason for revert: Code printout has become unreadable. Offsets are printed in decimal numbers everywhere else. This is inconsistent with the rest of the code-base. Some examples are tables for deoptimization data, safepoints and exception handlers. I would be fine with this change if _all_ tracing would be adapted. But there are _many_ places to touch. Original issue's description: > Decompiler improvements. > > The main motivation is simplifying profiling activities: > > 1) Use hex instead of decimal for offsets, just like perf does. This > affects --print-opt-code > > 2) When printing block information, indicate loop information: if > block is header, where the end is; if block is in a loop, where the > loop starts. This affects --code-comments. > > Using --print-opt-code --code-comments, and cross-referencing with data > obtained from perf, one may now find the block a hotspot belongs to > without needing to do hex2dec/dec2hex conversions. Once found, loop info > is available locally, on the block. > > BUG= > > Committed: https://crrev.com/32f4bd659d38eb5485eedb1d0dd236ff1bdc01d5 > Cr-Commit-Position: refs/heads/master@{#28964} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1188093002 Cr-Commit-Position: refs/heads/master@{#29046}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
Revert "Revert of Decompiler improvements. (patchset #2 id:20001 of https://codereview.chromium.org/1177123002/)" This reverts commit e2ce468, avoiding the hex->dec changes, and re-introducing the block pretty printing of the original CL. The hex-dec issue would be handled separately. BUG= Review URL: https://codereview.chromium.org/1186273005 Cr-Commit-Position: refs/heads/master@{#29063}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…id:20001 of https://codereview.chromium.org/1210393003/) Reason for revert: [Sheriff] Fails runhooks. Original issue's description: > Reland [android] Migrate more configs to gyp. > > This reverts commit 3e8892b. > > BUG=chromium:502176 > LOG=n > NOTRY=true > [email protected], [email protected] > > Committed: https://crrev.com/c0d70e43c4cbe2a09c8f1bd55fe2be03cd9ba041 > Cr-Commit-Position: refs/heads/master@{#29317} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:502176 Review URL: https://codereview.chromium.org/1215593004 Cr-Commit-Position: refs/heads/master@{#29319}
jugglinmike
pushed a commit
that referenced
this pull request
Feb 23, 2016
…(patchset #2 id:20001 of https://codereview.chromium.org/1683043003/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/1382/ Original issue's description: > Implement symbol @@hasInstance for ES6 instanceof support. > > BUG= > > Committed: https://crrev.com/5833e8e8a437cd66405784263ccc45e73470fd42 > Cr-Commit-Position: refs/heads/master@{#33870} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1686123002 Cr-Commit-Position: refs/heads/master@{#33871}
jugglinmike
pushed a commit
that referenced
this pull request
Feb 23, 2016
…tsStub. (patchset #2 id:20001 of https://codereview.chromium.org/1695633003/ ) Reason for revert: [Sheriff] Breaks ASAN with mipsel compile: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/4558/ Original issue's description: > [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. > > Turn the fast case of ArgumentsAccessStub into a new stub > FastNewSloppyArgumentsStub, which is similar to the existing > FastNewStrictArgumentsStub, although not polished yet, and the slow > case always went to the runtime anyway, so we can just directly emit > a runtime call there. > > [email protected] > > Committed: https://crrev.com/55b0b4f6d572531eec00ab6ebd8f6feb7c584e04 > Cr-Commit-Position: refs/heads/master@{#33973} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1701653002 Cr-Commit-Position: refs/heads/master@{#33976}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…#2 id:20001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: [Sheriff] Breaks local make builds. Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > NOTRY=true > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Review URL: https://codereview.chromium.org/1727383002 Cr-Commit-Position: refs/heads/master@{#34247}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…https://codereview.chromium.org/1722193002/ ) Reason for revert: Speculative revert in attempt to fix #2 crasher on canary. Original issue's description: > [compiler] Drop the CompareNilIC. > > Since both null and undefined are also marked as undetectable now, we > can just test that bit instead of having the CompareNilIC try to collect > feedback to speed up the general case (without the undetectable bit > being used). > > Drive-by-fix: Update the type system to match the new handling of > undetectable in the runtime. > > [email protected] > > Committed: https://crrev.com/666aec0348c8793e61c8633dee7ad29a514239ba > Cr-Commit-Position: refs/heads/master@{#34237} [email protected],[email protected],[email protected] LOG=y BUG=chromium:589897 NOTRY=true Review URL: https://codereview.chromium.org/1743433002 Cr-Commit-Position: refs/heads/master@{#34308}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…dereview.chromium.org/1738033002/ ) Reason for revert: An Intl change that this depends on breaks a bot Original issue's description: > Test262 roll, 2016-2-23 > > R=adamk > > Committed: https://crrev.com/34492040fbfb04fead21416245c8696b9847e751 > Cr-Commit-Position: refs/heads/master@{#34312} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1736223002 Cr-Commit-Position: refs/heads/master@{#34313}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…view.chromium.org/1736223002/ ) Reason for revert: Intl change relanded https://codereview.chromium.org/1745483002/ Original issue's description: > Revert of Test262 roll, 2016-2-23 (patchset #2 id:20001 of https://codereview.chromium.org/1738033002/ ) > > Reason for revert: > An Intl change that this depends on breaks a bot > > Original issue's description: > > Test262 roll, 2016-2-23 > > > > R=adamk > > > > Committed: https://crrev.com/34492040fbfb04fead21416245c8696b9847e751 > > Cr-Commit-Position: refs/heads/master@{#34312} > > [email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/3b829ad80628bf521aa78255c2e5e20040a57b5f > Cr-Commit-Position: refs/heads/master@{#34313} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1739533006 Cr-Commit-Position: refs/heads/master@{#34338}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. Attempt #2. First one was reverted due to chromium breakage: SetAutorunMicrotasks(false) was broken. BUG=chromium:585949 LOG=Y TEST=ScopedMicrotasks Review URL: https://codereview.chromium.org/1741893003 Cr-Commit-Position: refs/heads/master@{#34504}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…WASM modules from JavaScript. (patchset #2 id:20001 of https://codereview.chromium.org/1762203002/ ) Reason for revert: New test test-wasm-module-builder fails on Linux - shared bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8793 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > [email protected],[email protected] > BUG= > > Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc > Cr-Commit-Position: refs/heads/master@{#34513} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1771553002 Cr-Commit-Position: refs/heads/master@{#34514}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…up snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1780173002/ ) Reason for revert: Regresses performance on base64 benchmark. Original issue's description: > Allow Math.random to be called when creating a custom startup snapshot. > > [email protected] > BUG=v8:4810 > LOG=N > > Committed: https://crrev.com/6a7ec6a3bf779cdd41c66a768fd7a37195ed7b7f > Cr-Commit-Position: refs/heads/master@{#34705} [email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4810, chromium:594484 LOG=N Review URL: https://codereview.chromium.org/1798863003 Cr-Commit-Position: refs/heads/master@{#34739}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…up snapshot. (patchset #1 id:1 of https://codereview.chromium.org/1798863003/ ) Reason for revert: This seems not to change performance. Original issue's description: > Revert of Allow Math.random to be called when creating a custom startup snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1780173002/ ) > > Reason for revert: > Regresses performance on base64 benchmark. > > Original issue's description: > > Allow Math.random to be called when creating a custom startup snapshot. > > > > [email protected] > > BUG=v8:4810 > > LOG=N > > > > Committed: https://crrev.com/6a7ec6a3bf779cdd41c66a768fd7a37195ed7b7f > > Cr-Commit-Position: refs/heads/master@{#34705} > > [email protected] > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4810, chromium:594484 > LOG=N > > Committed: https://crrev.com/b7be51cd33bc81d768dbf5632ba0c68843448e37 > Cr-Commit-Position: refs/heads/master@{#34739} [email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4810, chromium:594484 LOG=N Review URL: https://codereview.chromium.org/1806713003 Cr-Commit-Position: refs/heads/master@{#34820}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…tchset #2 id:20001 of https://codereview.chromium.org/1810083003/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5506 Original issue's description: > Inline fast-path interceptor access in the IC utilities > > BUG= > > Committed: https://crrev.com/b3bda50ddd9e30b718ae7972d9dd0d095113f634 > Cr-Commit-Position: refs/heads/master@{#34892} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1819433003 Cr-Commit-Position: refs/heads/master@{#34905}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
…karound (patchset #2 id:20001 of https://codereview.chromium.org/1624383003/ ) Reason for revert: This patch actually seemed to cause a further GameBoy regression! Reverting it seems to address the regression. Original issue's description: > Restore per-TypedArray-class length accessors as a perf workaround > > This patch is a workaround to the performance regression caused by > implementing the ES2015 TypedArray prototype chain: Include a > per-TypedArray-subclass length getter so that the superclass getter does > not become polymorphic. The patch appears to fix a regression in the > Gameboy Octane benchmark. > > BUG=chromium:579905 > R=adamk > LOG=Y > > Committed: https://crrev.com/03ce7711e474a0ef74f723b30ae1527c89dec010 > Cr-Commit-Position: refs/heads/master@{#33501} [email protected] BUG=chromium:579905,chromium:593634 LOG=Y Review URL: https://codereview.chromium.org/1812143004 Cr-Commit-Position: refs/heads/master@{#34906}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2016
… id:20001 of https://codereview.chromium.org/1833643002/ ) Reason for revert: Makes nosnap bots timeout due to having to rebuild bytecode handlers. Original issue's description: > [Interpreter] Remove separate Ignition snapshot. > > Removes the seperate Ignition snapshot and build the Ignition bytecode > handlers in the default snapshot. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 > Cr-Commit-Position: refs/heads/master@{#35058} [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review URL: https://codereview.chromium.org/1827143002 Cr-Commit-Position: refs/heads/master@{#35059}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 1, 2016
…tchset #2 id:20001 of https://codereview.chromium.org/1837843002/ ) Reason for revert: TC39 decided that this compatibility fix should be standardized. Original issue's description: > Remove RegExp.prototype.source getter compat workaround > > The getter RegExp.prototype.source is specified in ES2015 to throw when > called on a non-RegExp instance, such as RegExp.prototype. We had previously > put in a compatibility workaround for all RegExp getters to make them > throw on access specifically with RegExp.prototype as the receiver; however, > we only have evidence that this is needed for properties other than source. > This patch removes the compatibility workaround for get RegExp.prototype.source > and gives it semantics precisely as per the ES2015 specification. > > R=adamk > BUG=chromium:581577,v8:4827 > LOG=Y > > Committed: https://crrev.com/80803aa89e31839b8f73959776fa7e1923c6b461 > Cr-Commit-Position: refs/heads/master@{#35086} [email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:581577,v8:4827 LOG=Y Review URL: https://codereview.chromium.org/1847783003 Cr-Commit-Position: refs/heads/master@{#35180}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 13, 2016
…rototype.charAt to TurboFan. (patchset #2 id:20001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/1838283003/ Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > [email protected] > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1870993002 Cr-Commit-Position: refs/heads/master@{#35351}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…https://codereview.chromium.org/1890083002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 Auto-bisect points to this CL. Original issue's description: > Immediately cache compiled scripts. > > Usually, script compilation is expensive enough to warrant the extra > overhead of caching scripts immediatly. > > BUG=chromium:588900 > [email protected] > LOG=n > > Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357 > Cr-Commit-Position: refs/heads/master@{#35527} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588900 Review URL: https://codereview.chromium.org/1882833006 Cr-Commit-Position: refs/heads/master@{#35536}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…tps://codereview.chromium.org/1882833006/ ) Reason for revert: Fixed webkit_unit_tests Original issue's description: > Revert of Immediately cache compiled scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1890083002/ ) > > Reason for revert: > [Sheriff] Breaks: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 > > Auto-bisect points to this CL. > > Original issue's description: > > Immediately cache compiled scripts. > > > > Usually, script compilation is expensive enough to warrant the extra > > overhead of caching scripts immediatly. > > > > BUG=chromium:588900 > > [email protected] > > LOG=n > > > > Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357 > > Cr-Commit-Position: refs/heads/master@{#35527} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:588900 > > Committed: https://crrev.com/f8a5a4da70d0a8e6dbb1b5c633c2b6b47fe5c3f6 > Cr-Commit-Position: refs/heads/master@{#35536} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:588900 LOG=n Review URL: https://codereview.chromium.org/1901573002 Cr-Commit-Position: refs/heads/master@{#35566}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…hset #2 id:20001 of https://codereview.chromium.org/1906963002/ ) Reason for revert: Need to fix the #undef logic. Original issue's description: > Fix interpreter unittest for embedded constant pools. > > The offset from fp to the register file is based on the frame size > -- which is one slot larger when embedded constant pools are enabled. > > TEST=unittests/DecodeBytecodeAndOperands > [email protected], [email protected], [email protected], [email protected] > BUG= [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1909323003 Cr-Commit-Position: refs/heads/master@{#35736}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…ncurrently. (patchset #2 id:20001 of https://codereview.chromium.org/1926023002/ ) Reason for revert: [Sheriff] Flaky crashed here and there: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9867 https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/9589 https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/7679 Original issue's description: > [turbofan] Run everything after representation selection concurrently. > > Further refactor the pipeline to even run the first scheduler (part of > the effect control linearization) concurrently. This temporarily > disables most of the write barrier elimination, but we will get back to > that later. [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1925073002 Cr-Commit-Position: refs/heads/master@{#35863}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…. (patchset #2 id:20001 of https://codereview.chromium.org/1941673002/ ) Reason for revert: [Sheriff] Breaks mac gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/5821 Original issue's description: > [turbofan] Remove left-over change bits from ChangeLowering. > > Now ChangeLowering is only concerned with lowering memory access and > allocation operations, and all changes are consistently lowered during > the effect/control linearization pass. The next step is to move the > left over lowerings to a pass dedicated to eliminate redundant loads and > stores, eliminate write barriers, fold and inline allocations. > > Also remove the atomic regions now that we wire everything into the > effect chain properly. This is an important step towards allocation > inlining. > > Drive-by-fix: Rename ChangeBitToBool to ChangeBitToTagged, > ChangeBoolToBit to ChangeTaggedToBit, and ChangeInt31ToTagged to > ChangeInt31ToTaggedSigned for consistency. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > Committed: https://crrev.com/ceca5ae308bddda166651c654f96d71d74f617d0 > Cr-Commit-Position: refs/heads/master@{#35924} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1942733002 Cr-Commit-Position: refs/heads/master@{#35927}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
#2 id:20001 of https://codereview.chromium.org/1938993002/ ) Reason for revert: Breaks WBs that should be there ;) https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 Will open repro bug asap. Original issue's description: > [turbofan] Restore basic write barrier elimination. > > Restore the basic write barrier elimination that we used to run as part > of the simplified lowering phase (in ChangeLowering actually) before, by > moving the write barrier computation to SimplifiedLowering where we can > still look at types and consider the heap/isolate, and just update the > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > lowering to a machine Load/Store. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > [email protected] > BUG=v8:4969,chromium:608636 > LOG=n > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > Cr-Commit-Position: refs/heads/master@{#35969} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943743003 Cr-Commit-Position: refs/heads/master@{#35983}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
#1 id:1 of https://codereview.chromium.org/1943743003/ ) Reason for revert: Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination. Original issue's description: > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) > > Reason for revert: > Breaks WBs that should be there ;) > > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 > > Will open repro bug asap. > > Original issue's description: > > [turbofan] Restore basic write barrier elimination. > > > > Restore the basic write barrier elimination that we used to run as part > > of the simplified lowering phase (in ChangeLowering actually) before, by > > moving the write barrier computation to SimplifiedLowering where we can > > still look at types and consider the heap/isolate, and just update the > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > > lowering to a machine Load/Store. > > > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > [email protected] > > BUG=v8:4969,chromium:608636 > > LOG=n > > > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > > Cr-Commit-Position: refs/heads/master@{#35969} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4969,chromium:608636 > > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 > Cr-Commit-Position: refs/heads/master@{#35983} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943323002 Cr-Commit-Position: refs/heads/master@{#35984}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…g ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ) Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1959603002 Cr-Commit-Position: refs/heads/master@{#36066}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…rowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ). port 3b7ff99 (r36066) original commit message: Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} BUG= Review-Url: https://codereview.chromium.org/1958863003 Cr-Commit-Position: refs/heads/master@{#36094}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…//codereview.chromium.org/1974773002/ ) Reason for revert: Addressed link failure Original issue's description: > Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ ) > > Reason for revert: > blocks roll: https://codereview.chromium.org/1975753002/ > > Original issue's description: > > Remove v8_toolset_for_d8 flag > > > > [email protected] > > BUG=chromium:609107 > > > > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 > > Cr-Commit-Position: refs/heads/master@{#36198} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:609107 > > Committed: https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e > Cr-Commit-Position: refs/heads/master@{#36209} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 Review-Url: https://codereview.chromium.org/1973363002 Cr-Commit-Position: refs/heads/master@{#36250}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…:20001 of https://codereview.chromium.org/1979883002/ ) Reason for revert: Blocks the roll again: https://codereview.chromium.org/1993163002/ https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/140169 Lets add chromeos_amd64-generic_chromium_compile_only_ng on a reland as well. Original issue's description: > Reland changes to v8_snapshot GN build arg. > > This patch re-lands #36193 with a couple of minor tweaks > including updating the BUILD.gn file to use the new > variable name and incorporating thakis' request to support > cross-compiling the win snapshot from a mac. > > [email protected], [email protected], [email protected] > BUG=608596, 595653 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng > > Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 > Cr-Commit-Position: refs/heads/master@{#36342} [email protected],[email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596, 595653 Review-Url: https://codereview.chromium.org/1996533002 Cr-Commit-Position: refs/heads/master@{#36347}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…https://codereview.chromium.org/1991713002/ ) Reason for revert: Crashes on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/2305/steps/Check/logs/stdio Also, would be nice if the test output could be a bit shorter and only print what's necessary to trace a failure. Or split things into more smaller tests. Like that, these logs must be processed, json-encoded/decoded and sent around through the infrastructure. Some chars in the output make the json encoder unhappy, therefore the infrastructure can't nicely display the failures. Original issue's description: > Adding ia32 simd assembler support. > > Based on assembler changes from this patch: > https://codereview.chromium.org/90643003/ > > BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 > [email protected] > LOG=N > > Committed: https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 > Cr-Commit-Position: refs/heads/master@{#36349} [email protected],[email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 Review-Url: https://codereview.chromium.org/1992163002 Cr-Commit-Position: refs/heads/master@{#36353}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
This patch is a follow up to https://codereview.chromium.org/1972103002/ adding support for the `Operand_R_LSL_I` addressing mode to loads and stores for ARM. Just as the ARM64 implementation, the shift + load/store pattern is only really relevant to the interpreter. For this reason, this patch does not add support for the other addressing modes (`R_LSR_I`, `R_ASR_I` and `R_ROR_I`) as I haven't seen those pattern being generated. Additionally, the optimization is restricted 32 bit loads and stores. kind = BYTECODE_HANDLER name = Star compiler = turbofan Instructions (size = 40) 0x22a5f860 0 e2851001 add r1, r5, #1 0x22a5f864 4 e19610d1 ldrsb r1, [r6, +r1] 0x22a5f868 8 e1a0200b mov r2, fp 0x22a5f86c 12 e7820101 str r0, [r2, +r1, lsl #2] ^^^^^^^^^^^^^^^^^^^^^^^^^ 0x22a5f870 16 e2855002 add r5, r5, #2 0x22a5f874 20 e7d61005 ldrb r1, [r6, +r5] 0x22a5f878 24 e7981101 ldr r1, [r8, +r1, lsl #2] ^^^^^^^^^^^^^^^^^^^^^^^^^ 0x22a5f87c 28 e12fff11 bx r1 BUG= Review-Url: https://codereview.chromium.org/1974263002 Cr-Commit-Position: refs/heads/master@{#36381}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…id:20001 of https://codereview.chromium.org/1991173002/ ) Reason for revert: This array only contains Smis, see its only store site five lines above: array->set(array_size++, Smi::FromInt(i)); If you want to improve something here, use a C++ array instead of a FixedArray. There's no reason to have this short-lived list on the V8 heap. Original issue's description: > [keys] Don't omit write barrier after std::sort > > BUG= > > Committed: https://crrev.com/681ac8979e820d147380b5fdb2aae773e22f1302 > Cr-Commit-Position: refs/heads/master@{#36412} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1996963002 Cr-Commit-Position: refs/heads/master@{#36414}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are derived from the following files within the Google V8
project:
test/mjsunit/es6/string-html.js