forked from v8/v8
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove tests for V8 internals #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jugglinmike
wants to merge
1
commit into
master
Choose a base branch
from
remove-internals-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These test files are dedicated to V8 internal implementation details (or regressions therein). Since they are not suitable for the Test262 project, they may be removed from this repository. Note that assertions for implementation details may exist in files not removed in this commit; this changeset is a preliminary coarse-grained attempt to remove assertions not necessary for the Test262 migration.
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…2. (patchset #1 id:1 of https://codereview.chromium.org/936323004/) Reason for revert: Breaks SQLite Original issue's description: > [x64] Improve instruction selection for TruncateInt64ToInt32. > > [email protected] > > Committed: https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c > Cr-Commit-Position: refs/heads/master@{#26739} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/928723003 Cr-Commit-Position: refs/heads/master@{#26791}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…//codereview.chromium.org/935243003/) Reason for revert: waterfall disagrees Original issue's description: > Turn on job based recompilation > > BUG=v8:3608 > [email protected] > LOG=y > > Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc > Cr-Commit-Position: refs/heads/master@{#26826} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Review URL: https://codereview.chromium.org/937263004 Cr-Commit-Position: refs/heads/master@{#26827}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
… of https://codereview.chromium.org/937263004/) Reason for revert: reland Original issue's description: > Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/935243003/) > > Reason for revert: > waterfall disagrees > > Original issue's description: > > Turn on job based recompilation > > > > BUG=v8:3608 > > [email protected] > > LOG=y > > > > Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc > > Cr-Commit-Position: refs/heads/master@{#26826} > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3608 > > Committed: https://crrev.com/35cc692aecdea54fb07479b8d7b71059851e07e8 > Cr-Commit-Position: refs/heads/master@{#26827} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Review URL: https://codereview.chromium.org/955723002 Cr-Commit-Position: refs/heads/master@{#26829}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…:1 of https://codereview.chromium.org/928733003/) Reason for revert: Preparing to land a fix. Original issue's description: > Temporarily disable double fields unboxing. > > Committed: https://crrev.com/209cf09ac9e36c1a24cdfa918bc579a4671c6842 > Cr-Commit-Position: refs/heads/master@{#26727} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/960173002 Cr-Commit-Position: refs/heads/master@{#26876}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…one builds. (patchset #1 id:1 of https://codereview.chromium.org/959693002/) Reason for revert: Breaks "Simple Leaks Check" Original issue's description: > Default-enable external startup data for Linux for stand-alone builds. > > Notes: > - Other platforms to follow later. > - This follows Chromium practice, that mostly uses this feature these days. > - The statically linked-in startup data will stay. So whoever prefers > the old way just needs to set the flag differently. > > BUG= > > Committed: https://crrev.com/6d0dcaabe55ca3556bebfd771fbc7fd560fdd4e0 > Cr-Commit-Position: refs/heads/master@{#26884} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/962593003 Cr-Commit-Position: refs/heads/master@{#26885}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…hset #1 id:1 of https://codereview.chromium.org/957413002/) Reason for revert: Need to revert the ported CL. Original issue's description: > MIPS: Also skip when the target is the global object. > > Port cc918d3 > > BUG= > > Committed: https://crrev.com/b24a0efa447235e11b9ff9d1eeaada06131b2e04 > Cr-Commit-Position: refs/heads/master@{#26897} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/963603002 Cr-Commit-Position: refs/heads/master@{#26898}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…ta to accessor. (patchset #1 id:1 of https://codereview.chromium.org/961003002/) Reason for revert: Breaks gc stress, e.g.: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/2322 Original issue's description: > Invalidate the global property cell when converting from data to accessor. > > BUG= > [email protected], > > Committed: https://crrev.com/6a12dc240b1faffa500ff269077d832ecc74239d > Cr-Commit-Position: refs/heads/master@{#26896} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/958113004 Cr-Commit-Position: refs/heads/master@{#26899}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…id:1 of https://codereview.chromium.org/961723002/) Reason for revert: Breaks unscopables and fix attempt needed to be reverted too. Original issue's description: > Also skip when the target is the global object > > BUG= > > Committed: https://crrev.com/cc918d30b9d586ce974b71232473f2ae3c5e7847 > Cr-Commit-Position: refs/heads/master@{#26887} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/960363002 Cr-Commit-Position: refs/heads/master@{#26900}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 3, 2015
…odereview.chromium.org/961353002/) Reason for revert: Fails on nosnap builds Original issue's description: > Regression test for v8:3930. > > [email protected],[email protected] > BUG=v8:3930 > LOG=N > > Committed: https://crrev.com/48fb3e83c5882e9818bc1e0a035864b465602aca > Cr-Commit-Position: refs/heads/master@{#26926} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/965043002 Cr-Commit-Position: refs/heads/master@{#26929}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…Float64Mul. (patchset #1 id:1 of https://codereview.chromium.org/958583003/) Reason for revert: Tanks on Atom and Haswell Original issue's description: > [x86] Use better left operand heuristic for Float64Add and Float64Mul. > > [email protected] > > Committed: https://crrev.com/9da259fb1f4ecfefeb2cf7efbe449d8aa1904032 > Cr-Commit-Position: refs/heads/master@{#26849} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/972243002 Cr-Commit-Position: refs/heads/master@{#26973}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…one builds. (patchset #1 id:1 of https://codereview.chromium.org/956373002/) Reason for revert: The CL caused two issues: - a weird build issue on V8 mips builder - d8 cannot be invoked via PATH, since then it doesn't find its external snapshot. The 2nd issue might even be WAI, but this needs more consideration. Original issue's description: > Default-enable external startup data for Linux for stand-alone builds. > > Notes: > - Other platforms to follow later. > - This follows Chromium practice, that mostly uses this feature these days. > - The statically linked-in startup data will stay. So whoever prefers > the old way just needs to set the flag differently. > > Reland crrev.com/959693002, once crrev.com/960883003 is in. > > [email protected] > BUG= > > Committed: https://crrev.com/a0bdb103b676b4c7fa6b9f2e7149e716549c05d1 > Cr-Commit-Position: refs/heads/master@{#26980} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/981463005 Cr-Commit-Position: refs/heads/master@{#26986}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…. (patchset #1 id:1 of https://codereview.chromium.org/978773002/) Reason for revert: build failures. Original issue's description: > Remove default value for number of threads in Isolate::Init. > > Just fixing a TODO. > > [email protected] > > Committed: https://crrev.com/fbcebbc5bdfd8eed82d121faf07b536eb3142fb7 > Cr-Commit-Position: refs/heads/master@{#26987} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/964743003 Cr-Commit-Position: refs/heads/master@{#26988}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
#1 id:1 of https://codereview.chromium.org/955723002/) Reason for revert: Breaks Octane on Arm64 running on Chrome. BUG=464538 Original issue's description: > Revert of Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/937263004/) > > Reason for revert: > reland > > Original issue's description: > > Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/935243003/) > > > > Reason for revert: > > waterfall disagrees > > > > Original issue's description: > > > Turn on job based recompilation > > > > > > BUG=v8:3608 > > > [email protected] > > > LOG=y > > > > > > Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc > > > Cr-Commit-Position: refs/heads/master@{#26826} > > > > [email protected] > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:3608 > > > > Committed: https://crrev.com/35cc692aecdea54fb07479b8d7b71059851e07e8 > > Cr-Commit-Position: refs/heads/master@{#26827} > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3608 > > Committed: https://crrev.com/3735a0851a9e2726f8b50a46a3bc770992328264 > Cr-Commit-Position: refs/heads/master@{#26829} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Review URL: https://codereview.chromium.org/984463003 Cr-Commit-Position: refs/heads/master@{#27052}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…:1 of https://codereview.chromium.org/993513009/) Reason for revert: Breaks arm.debug. Original issue's description: > Fix old space check in IsSlotInBlackObject. > > BUG= > > Committed: https://crrev.com/4f865389bcecdff6aa56512fab3a147507a95a51 > Cr-Commit-Position: refs/heads/master@{#27090} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/987303003 Cr-Commit-Position: refs/heads/master@{#27095}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
… id:1 of https://codereview.chromium.org/1014263002/) Reason for revert: It seems to cause crbug/469146. Original issue's description: > Allow compaction when incremental marking is on. > > BUG=chromium:450824 > LOG=NO > > Committed: https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 > Cr-Commit-Position: refs/heads/master@{#27267} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:450824 Review URL: https://codereview.chromium.org/1026813002 Cr-Commit-Position: refs/heads/master@{#27345}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…/codereview.chromium.org/1035643002/) Reason for revert: Crash in pdfjs benchmark. Original issue's description: > [turbofan] Enable --turbo-osr. > > [email protected] > BUG= > > Committed: https://crrev.com/50305aac39f90b6455305313db56ff3365ec96f5 > Cr-Commit-Position: refs/heads/master@{#27431} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1005163003 Cr-Commit-Position: refs/heads/master@{#27432}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 26, 2015
…etting script break points. (patchset #1 id:1 of https://codereview.chromium.org/999273003/) Reason for revert: Reland since the failure has been fixed in https://codereview.chromium.org/1035523005/ Original issue's description: > Revert of Debugger: deduplicate shared function info when setting script break points. (patchset v8#4 id:60001 of https://codereview.chromium.org/998253005/) > > Reason for revert: > Code caching failures. > > Original issue's description: > > Debugger: deduplicate shared function info when setting script break points. > > > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > > > BUG=v8:3960 > > LOG=N > > > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > > Cr-Commit-Position: refs/heads/master@{#27444} > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3960 > > Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b > Cr-Commit-Position: refs/heads/master@{#27448} [email protected] BUG=v8:3960 LOG=N Review URL: https://codereview.chromium.org/1037013002 Cr-Commit-Position: refs/heads/master@{#27472}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2015
…alid entries from the SlotsBuffer. (patchset #1 id:1 of https://codereview.chromium.org/1020853022/) Reason for revert: Reverting risky GC changes that block v8 roll. Original issue's description: > Use a slot that is located on a heap page when removing invalid entries from the SlotsBuffer. > > BUG=chromium:470801 > LOG=Y > > Committed: https://crrev.com/2f3a42f9a1d66ffc9d260d9700ff831c3aa1cd41 > Cr-Commit-Position: refs/heads/master@{#27467} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:470801 Review URL: https://codereview.chromium.org/1033163002 Cr-Commit-Position: refs/heads/master@{#27490}
jugglinmike
pushed a commit
that referenced
this pull request
Mar 31, 2015
…#1 id:1 of https://codereview.chromium.org/1013743006/) Reason for revert: Revert due to crash. Original issue's description: > [turbofan][arm64] Match fneg for -0.0 - x pattern. > > Note that this patch add an extra bit to the ArchOpcodeField. > > [email protected] > > Committed: https://crrev.com/fe7441225100660d01e66ce3bcaefe368f62df81 > Cr-Commit-Position: refs/heads/master@{#27494} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1041633002 Cr-Commit-Position: refs/heads/master@{#27495}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 3, 2015
…#1 id:1 of https://codereview.chromium.org/1045763002/) Reason for revert: Reverting due to JSOn parser failures Original issue's description: > Relax assert a little to fix flake on regress-3976 > > [email protected] > NOTRY=true > BUG= > > Committed: https://crrev.com/b20edd7772892ff8b2b280b35e521fbc2cc4a5f6 > Cr-Commit-Position: refs/heads/master@{#27515} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1050033003 Cr-Commit-Position: refs/heads/master@{#27561}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 3, 2015
…https://codereview.chromium.org/1043363005/) Reason for revert: breaks some devtools things Original issue's description: > make ToLocalCheck crash in release mode > > [email protected] > BUG= > > Committed: https://crrev.com/ce7cc5119c1e031bf1eb8476fbf5e55bef738f94 > Cr-Commit-Position: refs/heads/master@{#27585} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1057873003 Cr-Commit-Position: refs/heads/master@{#27589}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
(patchset v8#4 id:60001 of https://codereview.chromium.org/1134333005/)" This reverts commit 81c080e. Patchset #1 is the original CL. Patchset #2 fixes a handlification bug that caused the crash. [email protected] BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1143813002 Cr-Commit-Position: refs/heads/master@{#28497}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…set #1 id:1 of https://codereview.chromium.org/1150683002/) Reason for revert: Causes assertions to fire when serializing optimized code. Original issue's description: > Remove obsolete JSFunction::IsOptimizable predicate. > > This just delegates to SharedFunctionInfo::optimization_disabled and > was primarily used for assertions. Removing it due to misleading name > because already optimized functions reported being "non-optimizable". > > [email protected] > > Committed: https://crrev.com/181d7b85977eb752b19e1de902093783e31330ef > Cr-Commit-Position: refs/heads/master@{#28551} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1148973005 Cr-Commit-Position: refs/heads/master@{#28554}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…tps://codereview.chromium.org/1144223002/) Reason for revert: Regressed Sunspider. Original issue's description: > Avoid excessive GCs in small heaps. > > Small heaps and small heap growing factor can lead to excessive GCs in corner cases. > > Consider function F(old_gen_size, factor) that returns the number of bytes that > have to be allocated in the old generation to start incremental marking. > > F(4MB, 1.1) = 4MB (because of kMinimumOldGenerationAllocationLimit) > F(6MB, 1.1) = 2MB (because of kMinimumOldGenerationAllocationLimit) > F(8MB, 1.1) = 800KB > > Funtion F should be monotonic in old_gen_size, but it currently has a minimum > at kMinimumOldGenerationAllocationLimit. > > This CL makes F monotonic. > > BUG= > > Committed: https://crrev.com/22b1da99732b4db0754bf267ec470a2831216fb2 > Cr-Commit-Position: refs/heads/master@{#28549} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1152533002 Cr-Commit-Position: refs/heads/master@{#28558}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…remental marking with (patchset #1 id:1 of https://codereview.chromium.org/1151143002/) Reason for revert: Wasn't the reason... Original issue's description: > Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) > > Reason for revert: > [Sheriff] Speculative revert because chromebook is really misbehaving: > http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 > > I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. > > Original issue's description: > > Pass GC flags to incremental marker and start incremental marking with > > reduce memory footprint in idle notification. > > > > BUG= > > > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > > Cr-Commit-Position: refs/heads/master@{#28567} > > [email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 > Cr-Commit-Position: refs/heads/master@{#28568} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1157613002 Cr-Commit-Position: refs/heads/master@{#28569}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > [email protected] > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > [email protected],[email protected],[email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1149773003 Cr-Commit-Position: refs/heads/master@{#28608}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…(patchset #1 id:1 of https://codereview.chromium.org/1151373002/) Reason for revert: Broke V8 Linux - nosnap. Original issue's description: > Fixed a couple of failing DCHECK(has_pending_exception()). > > BUG=chromium:491062 > LOG=N > > Committed: https://crrev.com/62b56507cce3c57a2e1aebce6d34f29b3b64e762 > Cr-Commit-Position: refs/heads/master@{#28617} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:491062 Review URL: https://codereview.chromium.org/1148423004 Cr-Commit-Position: refs/heads/master@{#28619}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
… of https://codereview.chromium.org/1151283005/) Reason for revert: [Sheriff] This leads to several failures in chromium and blocks our roll: https://codereview.chromium.org/1154363002/ Bisect (https://codereview.chromium.org/1152553004/) points to this CL. Please add the failing chromium trybot on a reland of this CL. Original issue's description: > Use CLOCK_REALTIME_COARSE when available. > > On systems that have CLOCK_REALTIME_COARSE with good enough resolution, > we can avoid making a system call to get the current time; it's serviced > from the vDSO. > > This is v2 of the patch. v1 can be found at [0] but was reverted in [1] > because of Chromium sandbox restrictions. The necessary changes have > been applied upstream in [2]. > > [0] https://codereview.chromium.org/1125003002 > [1] https://codereview.chromium.org/1130083003 > [2] https://codereview.chromium.org/1133653002 > > BUG= > LOG=N > > Committed: https://crrev.com/28cea2b749f24ba33e6e0c8e343dd0d6258ee302 > Cr-Commit-Position: refs/heads/master@{#28639} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1154783003 Cr-Commit-Position: refs/heads/master@{#28656}
leobalter
pushed a commit
that referenced
this pull request
Jul 3, 2015
…atchset #1 id:1 of https://codereview.chromium.org/1151373002/ )" BUG=chromium:491062 LOG=N Review URL: https://codereview.chromium.org/1157273002 Cr-Commit-Position: refs/heads/master@{#28699}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
… id:1 of https://codereview.chromium.org/1887343002/ ) Reason for revert: Using types in ChangeLowering is generally unsafe. Original issue's description: > [turbofan] Remove the leftover LoadBuffer hacks. > > [email protected] > > Committed: https://crrev.com/20eff45de11609934be339dffe46276ff0a4bc22 > Cr-Commit-Position: refs/heads/master@{#35509} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1893893002 Cr-Commit-Position: refs/heads/master@{#35549}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…tchset #1 id:1 of https://codereview.chromium.org/1872143002/ ) Reason for revert: Looking at types in ChangeLowering is generally unsafe. Original issue's description: > [turbofan] Improve lowering of ObjectIs<Type> somewhat. > > If we already know that the input to one of the ObjectIs<Type> nodes is > TaggedPointer, we don't need to perform the Smi check at runtime. > > [email protected] > > Committed: https://crrev.com/4fc4978cee0bb7ad2ae8681a67b7032eba6a7d11 > Cr-Commit-Position: refs/heads/master@{#35368} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1893123002 Cr-Commit-Position: refs/heads/master@{#35551}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…tps://codereview.chromium.org/1882833006/ ) Reason for revert: Fixed webkit_unit_tests Original issue's description: > Revert of Immediately cache compiled scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1890083002/ ) > > Reason for revert: > [Sheriff] Breaks: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 > > Auto-bisect points to this CL. > > Original issue's description: > > Immediately cache compiled scripts. > > > > Usually, script compilation is expensive enough to warrant the extra > > overhead of caching scripts immediatly. > > > > BUG=chromium:588900 > > [email protected] > > LOG=n > > > > Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357 > > Cr-Commit-Position: refs/heads/master@{#35527} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:588900 > > Committed: https://crrev.com/f8a5a4da70d0a8e6dbb1b5c633c2b6b47fe5c3f6 > Cr-Commit-Position: refs/heads/master@{#35536} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:588900 LOG=n Review URL: https://codereview.chromium.org/1901573002 Cr-Commit-Position: refs/heads/master@{#35566}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
… values (patchset #1 id:1 of https://codereview.chromium.org/1860003002/ ) Reason for revert: node.js is updated now Original issue's description: > Revert of [api] Restrict Template::Set to take templates or primitive values (patchset #1 id:1 of https://codereview.chromium.org/1839983002/ ) > > Reason for revert: > Breaks node.js > > Original issue's description: > > [api] Restrict Template::Set to take templates or primitive values > > > > Embedders that passed in non-primitive values should either use > > getters/setters (templates) or install a native data property, > > otherwise, the values would all result in cross-context leaks > > > > BUG=none > > [email protected] > > LOG=y > > > > Committed: https://crrev.com/eebdee8eafa97849cc70c25f3fecf1b075bac248 > > Cr-Commit-Position: refs/heads/master@{#35244} > > [email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://crrev.com/e1674a24ca3cb92bb4e58d368b25767bd61a0dfa > Cr-Commit-Position: refs/heads/master@{#35264} [email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Review URL: https://codereview.chromium.org/1894993002 Cr-Commit-Position: refs/heads/master@{#35572}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…d:1 of https://codereview.chromium.org/1899783002/ ) Reason for revert: Broke InterpreterCreateArguments test on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6404 Original issue's description: > 32-bit linux: Force 16-byte stack alignment. > > clang assumes 16-byte stack alignment, but incoming stack alignment isn't > always guaranteed to be that way. It looks like v8 was lucky to not hit > this so far. > > See https://crbug.com/418554 -- this makes v8's standalone config match > Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 > > Maybe it's possible to change the caller of OnEntryHook() to guarantee > the right alignment, but matching Chromium's build flags here seems like > a good idea in general. > > BUG=v8:4928 > LOG=n > > Committed: https://crrev.com/3afb3324941625559635380ef98a2ee73e370a0a > Cr-Commit-Position: refs/heads/master@{#35597} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4928 Review URL: https://codereview.chromium.org/1895783004 Cr-Commit-Position: refs/heads/master@{#35599}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…e AccessorInfo (patchset #1 id:1 of https://codereview.chromium.org/1906453002/ ) Reason for revert: Needs other reverts too. Original issue's description: > Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset v8#8 id:140001 of https://codereview.chromium.org/1892533004/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1896103002/ > > Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 > > Original issue's description: > > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > > > MIPS port contributed by Balazs Kilvady <[email protected]> > > > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > > Cr-Commit-Position: refs/heads/master@{#35606} > > [email protected],[email protected],[email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1903093003 Cr-Commit-Position: refs/heads/master@{#35645}
jugglinmike
pushed a commit
that referenced
this pull request
Apr 22, 2016
…. (patchset #1 id:1 of https://codereview.chromium.org/1839763003/ ) Reason for revert: Appears to break Android crbug.com/604422 Original issue's description: > [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". > > Add this define to the config used for mksnapshot. This fixes a bug > where certain applications would fail at runtime on Chromecast. > > BUG=592660 > LOG=Y > Bug: internal b/27495984 > > Test: Formerly broken Cast apps load and run as expected. > > Committed: https://crrev.com/86357d5235ceba61c151f0b6e509bcb365860454 > Cr-Commit-Position: refs/heads/master@{#35183} [email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=592660,604422 LOG=n Review URL: https://codereview.chromium.org/1906373002 Cr-Commit-Position: refs/heads/master@{#35725}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
id:1 of https://codereview.chromium.org/1912923003/ ) Reason for revert: blocks rolling. See https://bugs.chromium.org/p/chromium/issues/detail?id=605349 for more information. This CL only triggers the problem earlier but is not the culprit. The real bug is under investigation by the GC team. Original issue's description: > Check for semaphore alignment on posix platforms. > > BUG=chromium:605349 > LOG=NO > > Committed: https://crrev.com/8d24472acfaf7e67ca20106cb1f405fc0590c849 > Cr-Commit-Position: refs/heads/master@{#35717} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:605349 LOG=N Review URL: https://codereview.chromium.org/1921533002 Cr-Commit-Position: refs/heads/master@{#35755}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…id:1 of https://codereview.chromium.org/1912923003/ )" This patch also fixed three misaligned semaphores. This reverts commit 80c73e2. BUG=chromium:605349 LOG=NO Review URL: https://codereview.chromium.org/1917923002 Cr-Commit-Position: refs/heads/master@{#35773}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…. (patchset #1 id:1 of https://codereview.chromium.org/1927543002/ ) Reason for revert: Now we do have a repro! https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3187/steps/Mjsunit%20-%20ignition%20-%20turbofan/logs/debug-stepin-builtin-.. Original issue's description: > [debugger] unskip mjsunit/debug-stepin-builtin-callback-opt. > > This test does not seem to fail any longer. > > [email protected] > BUG=v8:4690 > LOG=N > > Committed: https://crrev.com/f8e44fb5aaaa80cf2d39bc3164f2c962a6b57f5e > Cr-Commit-Position: refs/heads/master@{#35814} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4690 Review URL: https://codereview.chromium.org/1931433002 Cr-Commit-Position: refs/heads/master@{#35815}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…#1 id:1 of https://codereview.chromium.org/1929293002/ ) This moves __{define,lookup}{Getter,Setter}__ to builtins.cc. Compared to the first attempt, this patch now preserves non-spec-compliant legacy behavior and does not throw on failure. Original review: https://codereview.chromium.org/1904313004 Review-Url: https://codereview.chromium.org/1932163002 Cr-Commit-Position: refs/heads/master@{#35899}
jugglinmike
pushed a commit
that referenced
this pull request
May 1, 2016
…id:1 of https://codereview.chromium.org/1924403002/ ) Reason for revert: Breaks vtune-jit build, see https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/10670 Original issue's description: > Stop using deprecated hash_map in vtune-jit.cc. > > Fixes nodejs/node#6422. [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1940693002 Cr-Commit-Position: refs/heads/master@{#35917}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…ixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) Reason for revert: GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin Original issue's description: > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > BUG=chromium:598319 > LOG=N > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > Cr-Commit-Position: refs/heads/master@{#35970} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947473002 Cr-Commit-Position: refs/heads/master@{#35979}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
#1 id:1 of https://codereview.chromium.org/1943743003/ ) Reason for revert: Jakob found the actual issue with the CL and is going to land the fix after relanding the WB elimination. Original issue's description: > Revert of [turbofan] Restore basic write barrier elimination. (patchset #2 id:20001 of https://codereview.chromium.org/1938993002/ ) > > Reason for revert: > Breaks WBs that should be there ;) > > https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305 > > Will open repro bug asap. > > Original issue's description: > > [turbofan] Restore basic write barrier elimination. > > > > Restore the basic write barrier elimination that we used to run as part > > of the simplified lowering phase (in ChangeLowering actually) before, by > > moving the write barrier computation to SimplifiedLowering where we can > > still look at types and consider the heap/isolate, and just update the > > WriteBarrierKind in the FieldAccess/ElementAccess that we later use when > > lowering to a machine Load/Store. > > > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel > > [email protected] > > BUG=v8:4969,chromium:608636 > > LOG=n > > > > Committed: https://crrev.com/7dcb6ad379fbacbc8bdc8e11a6e50d680ffa3f62 > > Cr-Commit-Position: refs/heads/master@{#35969} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4969,chromium:608636 > > Committed: https://crrev.com/a782e93c617e728cded5ad878de11137a67891b7 > Cr-Commit-Position: refs/heads/master@{#35983} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4969,chromium:608636 Review-Url: https://codereview.chromium.org/1943323002 Cr-Commit-Position: refs/heads/master@{#35984}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…ixedArray (patchset #1 id:1 of https://codereview.chromium.org/1947473002/ ) Reason for revert: Unrelated to waterfall failures. Original issue's description: > Revert of [heap] Fix clearing slots for map and size during LeftTrimFixedArray (patchset #1 id:1 of https://codereview.chromium.org/1943263002/ ) > > Reason for revert: > GC-stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3305/steps/Mjsunit/logs/array-copywithin > > Original issue's description: > > [heap] Fix clearing slots for map and size during LeftTrimFixedArray > > > > BUG=chromium:598319 > > LOG=N > > > > Committed: https://crrev.com/5aa1d9c3cfde4389fb5a34e98a5dccbca9dc9f12 > > Cr-Commit-Position: refs/heads/master@{#35970} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:598319 > > Committed: https://crrev.com/a4129bb45a3bb8cc68bb2e07ee1e0a734f04ce4b > Cr-Commit-Position: refs/heads/master@{#35979} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:598319 Review-Url: https://codereview.chromium.org/1947503002 Cr-Commit-Position: refs/heads/master@{#35986}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…ereview.chromium.org/1955723003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1956223002/ Original issue's description: > Add GN targets for samples > > BUG=chromium:609107 > [email protected] > LOG=n > > Committed: https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065 > Cr-Commit-Position: refs/heads/master@{#36072} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 LOG=n Review-Url: https://codereview.chromium.org/1955353002 Cr-Commit-Position: refs/heads/master@{#36096}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…1 of https://codereview.chromium.org/1955013002/ ) Reason for revert: Clang roll with fix is in. Original issue's description: > [test] Skip failing test after clang roll. > > BUG=v8:4995 > LOG=n > NOTRY=true > [email protected], [email protected] > > Committed: https://crrev.com/6e6a7ea3a425bee65d856814bd361ddbf14811f5 > Cr-Commit-Position: refs/heads/master@{#36064} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4995 NOTRY=true LOG=n Review-Url: https://codereview.chromium.org/1960053002 Cr-Commit-Position: refs/heads/master@{#36119}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…tps://codereview.chromium.org/1963693004/ ) Reason for revert: Causes regressions. Original issue's description: > [build] Use -O2 on linux by default > > This switches O2 -> O3 to match chromium's configuration. > > This makes the difference between gn and gyp a bit smaller > before switching. > > BUG=chromium:474921 > LOG=n > > Committed: https://crrev.com/a37ab71e343b8cc24df05868b941a49e0c271376 > Cr-Commit-Position: refs/heads/master@{#36124} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/1958253004 Cr-Commit-Position: refs/heads/master@{#36135}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…#1 id:1 of https://codereview.chromium.org/1958153004/ ) Reason for revert: [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6700 Yang can tell you how to do the blink rebase dance if it was this CL. Original issue's description: > [debugger] Prevent shared function info duplicates > > Clear the list of shared function infos attached to a script before > compiling for live edit in order to avoid duplicates. This was lost in > 058deb2. > > [email protected] > BUG= > > Committed: https://crrev.com/592432977e6213364c243c396060c7b64687ddc3 > Cr-Commit-Position: refs/heads/master@{#36155} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/1973433002 Cr-Commit-Position: refs/heads/master@{#36165}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…codereview.chromium.org/1969793002/ ) Reason for revert: blocks roll: https://codereview.chromium.org/1975753002/ Original issue's description: > Remove v8_toolset_for_d8 flag > > [email protected] > BUG=chromium:609107 > > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 > Cr-Commit-Position: refs/heads/master@{#36198} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:609107 Review-Url: https://codereview.chromium.org/1974773002 Cr-Commit-Position: refs/heads/master@{#36209}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…id:1 of https://codereview.chromium.org/1966183003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1972303002/ Original issue's description: > [Reland] Implement CPU time for OS X and POSIX. > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > implements CPU time for OS X and POSIX to provide more accurate > accounting of CPU time used by each thread. > > BUG=v8:4984 > LOG=n > > Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 > Cr-Commit-Position: refs/heads/master@{#36213} [email protected],[email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Review-Url: https://codereview.chromium.org/1977753002 Cr-Commit-Position: refs/heads/master@{#36225}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…id:1 of https://codereview.chromium.org/1977753002/ ) Reason for revert: Not the culprit sorry. Original issue's description: > Revert of [Reland] Implement CPU time for OS X and POSIX. (patchset #1 id:1 of https://codereview.chromium.org/1966183003/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1972303002/ > > Original issue's description: > > [Reland] Implement CPU time for OS X and POSIX. > > > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > > implements CPU time for OS X and POSIX to provide more accurate > > accounting of CPU time used by each thread. > > > > BUG=v8:4984 > > LOG=n > > > > Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 > > Cr-Commit-Position: refs/heads/master@{#36213} > > [email protected],[email protected],[email protected],[email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4984 > > Committed: https://crrev.com/31b9ba3bc8fb93601cc73c83213b30e639d448b3 > Cr-Commit-Position: refs/heads/master@{#36225} [email protected],[email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Review-Url: https://codereview.chromium.org/1976603005 Cr-Commit-Position: refs/heads/master@{#36233}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
… code. (patchset #1 id:1 of https://codereview.chromium.org/1974003002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/1972303002/ Repro: - build chromium with this CL - out/Default/content_browsertests --gtest_filter=AccessibilityHitTestingBrowserTest.HitTestingInIframes Original issue's description: > Add V8.Execute histogram to measure time spent executing JS code. > > Adds a V8.Execute histogram to measure the amount of time spent executing > JS code. > > BUG=v8:4865 > LOG=N > > Committed: https://crrev.com/e8f5a2723cf54576b84322ac2ee6ef7abc9df056 > Cr-Commit-Position: refs/heads/master@{#36217} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4865 Review-Url: https://codereview.chromium.org/1970193003 Cr-Commit-Position: refs/heads/master@{#36234}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…//codereview.chromium.org/1974773002/ ) Reason for revert: Addressed link failure Original issue's description: > Revert of Remove v8_toolset_for_d8 flag (patchset #1 id:1 of https://codereview.chromium.org/1969793002/ ) > > Reason for revert: > blocks roll: https://codereview.chromium.org/1975753002/ > > Original issue's description: > > Remove v8_toolset_for_d8 flag > > > > [email protected] > > BUG=chromium:609107 > > > > Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 > > Cr-Commit-Position: refs/heads/master@{#36198} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:609107 > > Committed: https://crrev.com/b33f9a6f24edef8447adcfb028b7f1d6e291c34e > Cr-Commit-Position: refs/heads/master@{#36209} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 Review-Url: https://codereview.chromium.org/1973363002 Cr-Commit-Position: refs/heads/master@{#36250}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…bytecode handlers. (patchset #1 id:1 of https://codereview.chromium.org/1974293002/ ) Reason for revert: Causes cctest/test-serialize/SnapshotDataBlobWithWarmup failure on arm64: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/534 Original issue's description: > [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. > > Trying to reland http://crrev.com/1902823002. > > This time some blocks have been shuffled around in the AddStub so that the frame still doesn't get built for the fast path. > > Committed: https://crrev.com/567160122de0bdb78aea79a9faa0dc15a564484c > Cr-Commit-Position: refs/heads/master@{#36251} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1978993003 Cr-Commit-Position: refs/heads/master@{#36255}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…patchset #1 id:1 of https://codereview.chromium.org/1946883003/ ) Reason for revert: Reverted because of BUG=chromium:611885 Original issue's description: > Ship Turbofan optimization for try-catch and try-finally. > > Committed: https://crrev.com/b84b01e6d2d8a0ed1e6b9186a5af755bab4bac9a > Cr-Commit-Position: refs/heads/master@{#36005} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1994543002 Cr-Commit-Position: refs/heads/master@{#36309}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…id:1 of https://codereview.chromium.org/1995723004/ ) Reason for revert: Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3575 Original issue's description: > [test] add tests for async function stacktraces > > BUG=v8:4483 > [email protected] > > Committed: https://crrev.com/02f228eccdfcfab4081c2494ade52e54702b692c > Cr-Commit-Position: refs/heads/master@{#36365} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Review-Url: https://codereview.chromium.org/1997453004 Cr-Commit-Position: refs/heads/master@{#36369}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
This patch is a follow up to https://codereview.chromium.org/1972103002/ adding support for the `Operand_R_LSL_I` addressing mode to loads and stores for ARM. Just as the ARM64 implementation, the shift + load/store pattern is only really relevant to the interpreter. For this reason, this patch does not add support for the other addressing modes (`R_LSR_I`, `R_ASR_I` and `R_ROR_I`) as I haven't seen those pattern being generated. Additionally, the optimization is restricted 32 bit loads and stores. kind = BYTECODE_HANDLER name = Star compiler = turbofan Instructions (size = 40) 0x22a5f860 0 e2851001 add r1, r5, #1 0x22a5f864 4 e19610d1 ldrsb r1, [r6, +r1] 0x22a5f868 8 e1a0200b mov r2, fp 0x22a5f86c 12 e7820101 str r0, [r2, +r1, lsl #2] ^^^^^^^^^^^^^^^^^^^^^^^^^ 0x22a5f870 16 e2855002 add r5, r5, #2 0x22a5f874 20 e7d61005 ldrb r1, [r6, +r5] 0x22a5f878 24 e7981101 ldr r1, [r8, +r1, lsl #2] ^^^^^^^^^^^^^^^^^^^^^^^^^ 0x22a5f87c 28 e12fff11 bx r1 BUG= Review-Url: https://codereview.chromium.org/1974263002 Cr-Commit-Position: refs/heads/master@{#36381}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…id:1 of https://codereview.chromium.org/1992173002/ ) Reason for revert: First CF feedback is in, reverting for now until the know bugs are fixed. Original issue's description: > [ESNext] Activate async/await for ClusterFuzz > > BUG=v8:4483 > [email protected],[email protected],[email protected] > LOG=N > > Committed: https://crrev.com/c57cadfa09fa493141bf43c1c7b898187a71da19 > Cr-Commit-Position: refs/heads/master@{#36362} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Review-Url: https://codereview.chromium.org/2003503002 Cr-Commit-Position: refs/heads/master@{#36397}
jugglinmike
pushed a commit
that referenced
this pull request
May 24, 2016
…g ia32/x64 word comparison operators. (patchset #1 id:1 of https://codereview.chromium.org/1968453002/ ) Reason for revert: Breaks a KCS demo: BUG=chromium:611976 Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9 > Cr-Commit-Position: refs/heads/master@{#36136} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1995303003 Cr-Commit-Position: refs/heads/master@{#36413}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test files are dedicated to V8 internal implementation details (or
regressions therein). Since they are not suitable for the Test262
project, they may be removed from this repository.
Note that assertions for implementation details may exist in files not
removed in this commit; this changeset is a preliminary coarse-grained
attempt to remove assertions not necessary for the Test262 migration.