Repository navigation
Commit 9a6bcd5
committed
[fix](be) Scope filesystem error-code imports to their functions
### What problem does this PR solve?
Issue Number: None
Related PR: apache#67292
Problem Summary: With ENABLE_PCH=OFF and unity builds enabled, the IO unity translation unit includes err_utils.cpp before file_meta_cache.cpp. The namespace-scope ErrorCode using-directive then makes LIMIT_REACH ambiguous when the latter includes the generated protobuf enum. Move the using-directive into the two localfs_error overloads that need it, preserving the existing error-code mappings while preventing it from affecting sibling source files.
### Release note
None
### Check List (For Author)
- Test: Manual test. Reproduced the original ENABLE_PCH=OFF compile failure with ./build.sh --be -j100; build-support/clang-format.sh, build-support/check-format.sh, build-support/check-build-hygiene.sh, and git diff --check passed. Post-fix BE compilation is tracked in the compilation-only Draft PR.
- Behavior changed: No
- Does this need documentation: No1 parent 7ccfb97 commit 9a6bcd5
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | 31 | | |
34 | 32 | | |
35 | 33 | | |
| |||
86 | 84 | | |
87 | 85 | | |
88 | 86 | | |
| 87 | + | |
89 | 88 | | |
90 | 89 | | |
91 | 90 | | |
| |||
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
0 commit comments