Repository navigation
Commit 60f0f2e
committed
[fix](be) Fall back when row-store read-ahead is disabled
### What problem does this PR solve?
Issue Number: apache#67611
Related PR: apache#67292
Problem Summary: A point request can pass the read-ahead enable check and then observe either mutable feature switch disabled while loading its segment. The row-store helper asserted that the factory still returned a read-ahead object, aborting the BE. Reuse the already loaded segment and the original synchronous column iterator when the factory returns no object. A deterministic test closes each switch between segment loading and factory creation, reproduces SIGABRT before the fix, and verifies identical row-store bytes after the fix.
### Release note
Prevent BE aborts when query read-ahead or asynchronous File Cache writes are disabled during row-store point queries.
### Check List (For Author)
- Test: ASAN/PCH BE unit test PointQueryReadAheadTest.RowStoreFallsBackWhenReadAheadSwitchChanges passed; the same test reproduced SIGABRT before the fix. Build hygiene and clang-format 16 passed.
- Behavior changed: Yes; a runtime switch change falls back to the original reader.
- Does this need documentation: No; preserve the existing dynamic switch contract.1 parent 47d9e5e commit 60f0f2e
2 files changed
Lines changed: 73 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
176 | 175 | | |
177 | 176 | | |
178 | 177 | | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
179 | 185 | | |
180 | 186 | | |
181 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
| 37 | + | |
33 | 38 | | |
34 | 39 | | |
35 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
36 | 102 | | |
37 | 103 | | |
38 | 104 | | |
| |||
0 commit comments