Add `PlainDateTime.prototype.round` implementation from `temporal_rs` by nekevss · Pull Request #4164 · boa-dev/boa

nekevss · 2025-02-18T03:42:47Z

This Pull Request fixes/closes #1804 and #4072.

It changes the following:

Adds the PlainDateTime::round implementation from temporal_rs
Bumps temporal_rs and related adjustments for time zone parsing

github-actions · 2025-02-18T04:01:19Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	50,254	50,254	0
Passed	46,211	46,261	+50
Ignored	1,634	1,634	0
Failed	2,409	2,359	-50
Panics	0	0	0
Conformance	91.95%	92.05%	+0.10%

Fixed tests (52):

test/intl402/Temporal/Now/zonedDateTimeISO/timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-datetime.js (previously Failed)
test/intl402/Temporal/Instant/prototype/toString/timezone-string-datetime.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/balance.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfexpand-is-default.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-string-shorthand.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/rounding-direction.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-trunc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-divides.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-non-integer.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-one-day.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Now/plainDateISO/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Now/plainTimeISO/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-valid.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/toString/timezone-string-leap-second.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-timezone-string-leap-second.js (previously Failed)

Broken tests (2):

test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object-insufficient-data.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object.js (previously Passed)

nekevss · 2025-02-18T04:50:09Z

The two broken tests for round are fixed by the linked PR.

This also requires manually validating against the TimeZoneProvider. Hopefully this could be improved upon in temporal_rs.

core/engine/src/builtins/temporal/zoneddatetime/mod.rs

Co-authored-by: José Julián Espina <[email protected]>

This PR requires a little more testing, but posting as a draft in the meantime. The changes made are related to adding validation details in boa-dev/boa#4164 into `temporal_rs`'s unit validations, which is incredibly important for `PlainDateTime::round` conformance.

nekevss added 4 commits February 17, 2025 21:36

Add the PlainDateTime::round impl

1e34ed9

Bump temporal_rs and make adjustments from changes

42e64ed

Fix timezone parse impl

93644b6

Add missing extra value to method

2f1de33

nekevss mentioned this pull request Feb 18, 2025

Update unit group validation to handle rounding options boa-dev/temporal#194

Merged

2 tasks

Manually check the identifer using the TimeZoneProvider

6e55f8e

nekevss requested a review from a team February 18, 2025 05:07

nekevss added the C-Builtins PRs and Issues related to builtins/intrinsics label Feb 18, 2025

Only validate IANA identifier strings

86e4045

jedel1043 reviewed Feb 18, 2025

View reviewed changes

core/engine/src/builtins/temporal/zoneddatetime/mod.rs Outdated Show resolved Hide resolved

nekevss and others added 2 commits February 17, 2025 23:56

Update core/engine/src/builtins/temporal/zoneddatetime/mod.rs

5cb186a

Co-authored-by: José Julián Espina <[email protected]>

Validate IANA ids in zdt constructor

0f7fbf9

nekevss requested review from a team and jedel1043 February 18, 2025 16:56

raskad approved these changes Feb 18, 2025

View reviewed changes

raskad requested a review from a team February 18, 2025 17:32

jedel1043 approved these changes Feb 19, 2025

View reviewed changes

jedel1043 added this pull request to the merge queue Feb 19, 2025

Merged via the queue into main with commit f0abe2c Feb 19, 2025
14 checks passed

jedel1043 deleted the impl-dt-round branch February 19, 2025 05:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `PlainDateTime.prototype.round` implementation from `temporal_rs`#4164

Add `PlainDateTime.prototype.round` implementation from `temporal_rs`#4164
jedel1043 merged 8 commits intomainfrom
impl-dt-round

nekevss commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 18, 2025 •

edited

Loading

Uh oh!

nekevss commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nekevss commented Feb 18, 2025

Uh oh!

github-actions bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test262 conformance changes

Uh oh!

nekevss commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 18, 2025 •

edited

Loading