Skip to content

Pre-releases should also require major version bumps on breaking changes #265

Open

Description

@dcharkes

Describe the bug
When a package is labeled pre-release, breaking changes are not flagged as requiring a package major version bump.

For example:

Actual and Expected behavior

Actual behavior: breaking changes but success true.

  "version": {
    "success": true,
    "old": "1.6.3",
    "new": "1.6.4-wip",
    "needed": "1.6.4-wip",
    "explanation": "We got a pre release. We only check if there are any changes. Got \"1.6.4-wip\" which is > \"1.6.3\" (pre-release but changes)"
  },
  "report": {
    "breakingChanges": {
      "label": "BREAKING CHANGES",

Expected behavior: breaking changes and success false.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions