Merged
Conversation
Owner
|
Good stuff! Thanks for the pull request. I am personally not a fan of checking in IDE project files into VCS as they can easily be generated in most cases. Was there a specific reason to why you wanted to add the STS project files? |
Author
|
They can be generated, but the ones I committed are updated from the ones that Grails generates - they work with the latest version of GGTS (it currently has to fix the ones Grails generates) and unused folders are excuded. I also change the GGTS class directory to target/eclipseclasses so everything that's generated is in one place. But of course feel free to revert that commit - I intentionally split the changes into separate commits so you can choose which to incorporate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.