Separate analysis from graph, esModuleFlag as analysis info#3
Open
guybedford wants to merge 2 commits intomasterfrom
Open
Separate analysis from graph, esModuleFlag as analysis info#3guybedford wants to merge 2 commits intomasterfrom
guybedford wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
analysis.js.{ staticAssignmentNames, exportsAllFrom, esModuleFlag }, whereexportsAllFromare unresolved specifiers andesModuleFlagis a boolean indicating if an__esModuleflag was set to truthy.defaultfiltering is no longer included by default - rather it is down to the exact wrapper module implementation to handle this. In discussion with @jkrems we were able to come to a compromise thatdefaultshould always be present on CommonJS module representations.