Add loading animation to the Video widget#2397
Merged
rafaellehmkuhl merged 1 commit intobluerobotics:masterfrom Feb 6, 2026
Merged
Add loading animation to the Video widget#2397rafaellehmkuhl merged 1 commit intobluerobotics:masterfrom
rafaellehmkuhl merged 1 commit intobluerobotics:masterfrom
Conversation
ES-Alexander
reviewed
Feb 6, 2026
Contributor
ES-Alexander
left a comment
ES-Alexander
left a comment
There was a problem hiding this comment.
Nice!
Haven't tested so can't approve yet, but generally looks good, and I suspect will make for a friendlier interface.
Nothing blocking, just a couple of small suggestions so far.
rafaellehmkuhl
force-pushed
the
improve-video-widget-loading
branch
from
24e98b1 to
5710381
Compare
Member
Author
|
@ArturoManzoli both done. |
ArturoManzoli
approved these changes
Feb 6, 2026
Contributor
ArturoManzoli
left a comment
ArturoManzoli
left a comment
There was a problem hiding this comment.
Approved, just gotta check the ci before merging
rafaellehmkuhl
force-pushed
the
improve-video-widget-loading
branch
from
5710381 to
abc9cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video-widget.mp4
Fix #2395