mavlink: Allows disabling the generation of legacy data-lake variables#2376
Merged
rafaellehmkuhl merged 1 commit intobluerobotics:masterfrom Jan 28, 2026
Merged
Conversation
rafaellehmkuhl
force-pushed
the
allow-disabling-legacy-vars
branch
from
4bfdc51 to
f7b0737
Compare
ArturoManzoli
requested changes
Jan 28, 2026
|
|
||
| // Store setting to enable/disable legacy data lake variable names (e.g., 'ATTITUDE/roll' in addition to '/mavlink/1/1/ATTITUDE/roll') | ||
| // Disabled by default for performance - enabling this doubles the number of setDataLakeVariableData calls per message | ||
| const enableLegacyDataLakeVariableNames = useBlueOsStorage('cockpit-enable-legacy-datalake-variable-names', true) |
Contributor
There was a problem hiding this comment.
Shouldn't enableLegacyDataLakeVariableNames be on false by default?
The MAVLink configuration switch tooltip says: "Disabled by default for better performance."
Member
Author
There was a problem hiding this comment.
I should actually update the comment. Originally I intended to disable by default, but that would cause users to see their VGIs, Plotters, Actions and others that are connected to legacy variables to stop working. In the end I realized this only impact performance for those with low-end setups, so better to maintain compatibility for now and allow those with low-end setups to just disable this as needed.
rafaellehmkuhl
force-pushed
the
allow-disabling-legacy-vars
branch
from
f7b0737 to
6c80495
Compare
rafaellehmkuhl
force-pushed
the
allow-disabling-legacy-vars
branch
from
6c80495 to
9852559
Compare
ArturoManzoli
approved these changes
Jan 28, 2026
rafaellehmkuhl
force-pushed
the
allow-disabling-legacy-vars
branch
from
9852559 to
4862b26
Compare
The generation of those legacy variables can cause a performance overhead in the application. This patch allows users to disable them if necessary (e.g.: when running on low-end machines).
rafaellehmkuhl
force-pushed
the
allow-disabling-legacy-vars
branch
from
4862b26 to
c09f215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are variables in the legacy ID pattern. For compatibility purposes, we generate them by default.
The generation of those legacy variables can cause a performance overhead in the application, as it basically doubles the amount of data-lake variables in the system.
This patch allows users to disable them if necessary (e.g.: when running on low-end machines).