Nice fixes! Just one point to keep in mind: I don't think this PR fixes #2301. The idea with that OKR is to allow joysticks with extra buttons to use the Visual tab, not the Table tab (as they currently do).

I don't think we need to extend that to support flight-sticks necessarily, but there should be a way for users with regular joysticks that have more than 17 buttons to see those extra ones there and assign commands to them, as the buttons in the SVG do. One idea that was brought up was to add a row with extra circles beneath the SVG for that. It was also brought up the idea of allowing those circles/forms to be dragged over the SVG, so the user can put them where it's more or less clear where those buttons are physically.

As this PR already fixes existing bugs, I would say we can just remove its relation to #2301, merge it, and have a new PR for that issue.

Nice fixes! Just one point to keep in mind: I don't think this PR fixes #2301. The idea with that OKR is to allow joysticks with extra buttons to use the Visual tab, not the Table tab (as they currently do).

I don't think we need to extend that to support flight-sticks necessarily, but there should be a way for users with regular joysticks that have more than 17 buttons to see those extra ones there and assign commands to them, as the buttons in the SVG do. One idea that was brought up was to add a row with extra circles beneath the SVG for that. It was also brought up the idea of allowing those circles/forms to be dragged over the SVG, so the user can put them where it's more or less clear where those buttons are physically.

Your'e right! Haha 😄
I mixed up the context. My bad.

Nice fixes! Just one point to keep in mind: I don't think this PR fixes #2301. The idea with that OKR is to allow joysticks with extra buttons to use the Visual tab, not the Table tab (as they currently do).
I don't think we need to extend that to support flight-sticks necessarily, but there should be a way for users with regular joysticks that have more than 17 buttons to see those extra ones there and assign commands to them, as the buttons in the SVG do. One idea that was brought up was to add a row with extra circles beneath the SVG for that. It was also brought up the idea of allowing those circles/forms to be dragged over the SVG, so the user can put them where it's more or less clear where those buttons are physically.

As this PR already fixes existing bugs, I would say we can just remove its relation to #2301, merge it, and have a new PR for that issue.

Agreed, lets do like you said

Nice fixes! Just one point to keep in mind: I don't think this PR fixes #2301. The idea with that OKR is to allow joysticks with extra buttons to use the Visual tab, not the Table tab (as they currently do).
I don't think we need to extend that to support flight-sticks necessarily, but there should be a way for users with regular joysticks that have more than 17 buttons to see those extra ones there and assign commands to them, as the buttons in the SVG do. One idea that was brought up was to add a row with extra circles beneath the SVG for that. It was also brought up the idea of allowing those circles/forms to be dragged over the SVG, so the user can put them where it's more or less clear where those buttons are physically.

As this PR already fixes existing bugs, I would say we can just remove its relation to #2301, merge it, and have a new PR for that issue.

Done removing relations