src: mini-widgets: ViewSelector: re-add visibility filtering#2292
Merged
ES-Alexander merged 1 commit intobluerobotics:masterfrom Dec 10, 2025
Merged
src: mini-widgets: ViewSelector: re-add visibility filtering#2292ES-Alexander merged 1 commit intobluerobotics:masterfrom
ES-Alexander merged 1 commit intobluerobotics:masterfrom
Conversation
rafaellehmkuhl
approved these changes
Dec 10, 2025
Member
rafaellehmkuhl
left a comment
rafaellehmkuhl
left a comment
There was a problem hiding this comment.
I remember we changed that because we could not directly change the viewToShow as it was being used elsewhere.
Your approach seems correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial reversion of #965, because the previous variable filters out hidden views, whereas the base list just includes all of them.
I have checked that it works, but I'm also unsure whether we should just go back to the old variable. It's not clear why it was changed away from.