widgets: collapsible-container: avoid shallow construction#2237
Merged
ES-Alexander merged 1 commit intobluerobotics:masterfrom Nov 17, 2025
Merged
Conversation
rafaellehmkuhl
approved these changes
Nov 17, 2025
ES-Alexander
deleted the
fix-collapsible-container-shallow-construction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1527. This is just intended to fix the problem of unintentionally linked container widgets - it unfortunately doesn't follow the suggested solution of allowing for intentionally linked ones (covered by #1690).
By deeply copying the default container elements, there is no longer cross-pollution of references to them between newly created widget containers. Ideally the defaults shouldn't be set in a special case in the widget manager, but I decided to keep this PR simple and make the smallest fixing change I could, especially given implementing #2114 will likely rework a bunch of the relevant code anyway.
Before:
Screen.Recording.2025-11-17.at.7.34.23.pm.mov
After:
Screen.Recording.2025-11-17.at.7.36.30.pm.mov