joystick: sdl: Prevent "JavaScript error" popups from appearing on joystick connection#2197
Merged
rafaellehmkuhl merged 1 commit intobluerobotics:masterfrom Oct 22, 2025
Conversation
…ystick connection Those were happening because the joystick can take some time to be fully opened, and we are fetching its state right away. A try/catch block with a warning was added to make sure this popup does not appear.
ArturoManzoli
approved these changes
Oct 22, 2025
Contributor
ArturoManzoli
left a comment
ArturoManzoli
left a comment
There was a problem hiding this comment.
Couldn't reproduce it here without an 8bitDo, even though I tried with different joysticks.
The logic seem correct and okay to merge anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those were happening because the joystick can take some time to be fully opened, and we are fetching its state right away.
A try/catch block with a warning was added to make sure this popup does not appear.
Fix #2195