BugFix: mission-planning: prevent shared command reference across wayoints#2169
Merged
ArturoManzoli merged 1 commit intobluerobotics:masterfrom Oct 8, 2025
Conversation
rafaellehmkuhl
requested changes
Oct 8, 2025
src/views/MissionPlanningView.vue
Outdated
Comment on lines
539
to
540
| const cloneCommands = (cmds?: MissionCommand[]): MissionCommand[] => | ||
| cmds && cmds.length ? cmds.map((c) => ({ ...c })) : makeDefaultNavCommands() |
Member
There was a problem hiding this comment.
Can we make a "regular" if/else function out of this one? I think this kind-of-one-liner may be unnecessarily hard to read.
…oints Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
fix-commands-added-on-all-wp-bug
branch
from
5dc856e to
dec97cb
Compare
rafaellehmkuhl
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a modification made to the base waypoint command in mission planning, a bug was introduced that caused all waypoints to share the same reference within the mission array. As a result, adding a command to the first waypoint would apply the same command to all others in the mission. (1)
(1)
reference_bug.mp4