Bugfix: default cruise speed not working#2158
Bugfix: default cruise speed not working#2158ArturoManzoli merged 3 commits intobluerobotics:masterfrom
Conversation
src/views/MissionPlanningView.vue
Outdated
| { | ||
| type: MissionCommandType.MAVLINK_NAV_COMMAND, | ||
| command: MavCmd.MAV_CMD_DO_CHANGE_SPEED, | ||
| param1: 0, |
There was a problem hiding this comment.
Should that be 0 (air speed) or 1 (ground speed)?
I'm thinking that ground speed could be a better general default as it demands GPS, which is the one usually present, but I don't know if maybe using air speed makes it fallback to the EKF if GPS is not present or something like that.
@Williangalvani any idea?
There was a problem hiding this comment.
There will be more use cases for ground speed for now.
I agree to change param1 to 1
ArturoManzoli
force-pushed
the
fix-default-cruise-speed-bug
branch
from
e5b5ee1 to
8de6f79
Compare
src/views/MissionPlanningView.vue
Outdated
| type: MissionCommandType.MAVLINK_NAV_COMMAND, | ||
| command: MavCmd.MAV_CMD_DO_CHANGE_SPEED, | ||
| param1: 1, | ||
| param2: defaultCruiseSpeed.value, |
There was a problem hiding this comment.
I believe the problem could be that we need to cast the defaultCruiseSpeed.value here to a number.
|
@ArturoManzoli it would be good to get this one merged as well, now that we are extending the boat capabilities in cockpit. |
Agreed, almost done with it. Tomorrow we have a test day |
ArturoManzoli
force-pushed
the
fix-default-cruise-speed-bug
branch
from
8de6f79 to
bdccd2c
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
fix-default-cruise-speed-bug
branch
from
bdccd2c to
0093ee8
Compare
All tested and ready to review! Also moved the cruise speed input to a place relative to the mission, not only the simple path or surveys 
|
2 participants
Ensures default cruise speed, if different than 1 m/s, will take effect on the planned mission.
Closes #2157