Nice!

One question: any reason for us not to use the same mechanism we have today in the survey?

Nice!

One question: any reason for us not to use the same mechanism we have today in the survey?

Do you mean the plus icon that appears in the middle of the segment?

Survey creation is a transient state, and mission paths are persistent, so we’d need to display plus icons on all segments at all times.
To address this, we’ would either need to implement and toggle an 'Add Waypoint' mode or show the plus icons only when hovering over segments.

However, hovering only works with pointing devices like a mouse, meaning mobile and Steam Deck users wouldn’t be able to access them. (Hover based interactions will always need to be a secondary option)

To accommodate all platforms while keeping the UI clean, was implemented the long press/double-tap for mobile and Steam Deck. For desktop users with a keyboard and mouse, using Ctrl to add and Shift to remove (just like in Adobe Photoshop) is a well established and intuitive pattern.

Nice!

One question: any reason for us not to use the same mechanism we have today in the survey?

Do you mean the plus icon that appears in the middle of the segment?

Survey creation is a transient state, and mission paths are persistent, so we’d need to display plus icons on all segments at all times.

To address this, we’ would either need to implement and toggle an 'Add Waypoint' mode or show the plus icons only when hovering over segments.

However, hovering only works with pointing devices like a mouse, meaning mobile and Steam Deck users wouldn’t be able to access them. (Hover based interactions will always need to be a secondary option)

To accommodate all platforms while keeping the UI clean, was implemented the long press/double-tap for mobile and Steam Deck. For desktop users with a keyboard and mouse, using Ctrl to add and Shift to remove (just like in Adobe Photoshop) is a well established and intuitive pattern.

For mouse-based devices, can we have the plus icon to show on hover?

@ArturoManzoli since my last review was in a comment, without clicking the request for changes button, ping me when you have finished and the PR is ready for review again.

@ArturoManzoli since my last review was in a comment, without clicking the request for changes button, ping me when you have finished and the PR is ready for review again.

Yup, thanks. I just gotta solve some conflicts between the new command waypoint markers and the ones coming on this PR.

@rafaellehmkuhl Ready to review!

Implementation-wise this look perfect. It's also working fine in all tested modes.

I have just one question: when adding a waypoint, it copies the previous one, so if the previous waypoint has extra commands, the new one will also have. Is this a feature or a bug? I can see reasons to go for both directions, but was expecting for bare default waypoints to be added, initially.

Kapture.2025-09-26.at.17.39.08.mp4

This was actually intentional so the behavior of the vehicle would stay consistent throughout the mission even on passing by newly added waypoints.

But thinking againg, also repeating the previous commands might represent a problem and should be removed from the insertWaypointAtSegmentMidpoint function. I'll do that.

I have just one question: when adding a waypoint, it copies the previous one, so if the previous waypoint has extra commands, the new one will also have. Is this a feature or a bug? I can see reasons to go for both directions, but was expecting for bare default waypoints to be added, initially.

Done! Also added a commit that extracts the default commands for general use inside the component