Skip to content

Comments

video: Fix 4K video processing#1920

Merged
rafaellehmkuhl merged 3 commits intobluerobotics:masterfrom
rafaellehmkuhl:skip-failed-video-thumbnail-generation
Jun 2, 2025
Merged

video: Fix 4K video processing#1920
rafaellehmkuhl merged 3 commits intobluerobotics:masterfrom
rafaellehmkuhl:skip-failed-video-thumbnail-generation

Conversation

@rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jun 2, 2025

They way that the processing pipeline works right now, we have 3 main things happening:

  1. Video is processed (chunks merged and duration fixed)
  2. Video thumbnail is generated
  3. Video subtitles (telemetry) is generated

The problem that is happening is that the current video thumbnail extraction, for some reason that is still not clear, is not working for 4K videos, like the ones generated by Radcam. Those videos are also not playable in the embeded video player that we have in the video library modal.

The video is correctly processed, but as the thumbnail is failing to be generated, it is breaking the processing pipeline, causing the subtitles not to be generated, and the user to receive an error message saying the processing failed.

My solution does the following:

  1. Puts the thumbnail extraction inside a try/catch block, so if it fails, it generates a placeholder thumbnail
  2. Puts a message on the embedded video player saying a video cannot by played (if it cannot be played) and saying it should instead be downloaded

Fix #1761

@rafaellehmkuhl rafaellehmkuhl force-pushed the skip-failed-video-thumbnail-generation branch from cce70f3 to d5f2e62 Compare June 2, 2025 17:36
@rafaellehmkuhl rafaellehmkuhl changed the title video: Generate placeholder thumbnails when extraction fails and move with the video processing video: Fix 4K video processing Jun 2, 2025
@rafaellehmkuhl rafaellehmkuhl merged commit 2160a25 into bluerobotics:master Jun 2, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the skip-failed-video-thumbnail-generation branch June 2, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subtitles not being generated on standalone version

2 participants