video: Fix 4K video processing#1920
Merged
rafaellehmkuhl merged 3 commits intobluerobotics:masterfrom Jun 2, 2025
Merged
Conversation
ArturoManzoli
approved these changes
Jun 2, 2025
cce70f3 to
d5f2e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They way that the processing pipeline works right now, we have 3 main things happening:
The problem that is happening is that the current video thumbnail extraction, for some reason that is still not clear, is not working for 4K videos, like the ones generated by Radcam. Those videos are also not playable in the embeded video player that we have in the video library modal.
The video is correctly processed, but as the thumbnail is failing to be generated, it is breaking the processing pipeline, causing the subtitles not to be generated, and the user to receive an error message saying the processing failed.
My solution does the following:
Fix #1761