The code here seems fine to me, although we may want to add some logging for which boards have been detected.

From a cleanliness standpoint, Detector.detect_serial_flight_controllers should be a classmethod not a staticmethod, but perhaps that's out of scope for this PR since it'd change the existing code?

so... this will not work as we don't actually try to talk mavlink to identify the boards. (we only check for usb pid/vid)
perhaps we really need an override option?

perhaps we really need an override option?

Not sure how annoying it'd be to implement, but it presumably would be quite useful for people if there was a config file of 'extras' where each line just specifies a device path or something to try to connect to?

We could just add a function here that sets one
https://github.com/bluerobotics/BlueOS-docker/blob/master/core/services/ardupilot_manager/flight_controller_detector/Detector.py#L62

All committers have signed the CLA.