Allow 3d Model overrides#1440
Merged
patrickelectric merged 4 commits intobluerobotics:masterfrom Feb 13, 2023
Merged
Conversation
Williangalvani
force-pushed
the
model_overrides
branch
2 times, most recently
from
1753e45 to
1c9a057
Compare
Member
Author
|
onte interesting issue here. we cant make 404 fail quietly. so even if it works as intended, there's a bunch of red lines in the terminal. I tries using the HEAD request to check if things exist, but it also 404s. so maybe we could add something in nginx to make it fail in a nicer way. |
Williangalvani
force-pushed
the
model_overrides
branch
5 times, most recently
from
5bb214d to
5853437
Compare
Member
Author
|
for testing a custom model, set frame to VECTORED_6DOF and unzip this package at /usr/blueos/userdata: |
Member
Author
|
you should see something like this |
Williangalvani
requested review from
ES-Alexander and
patrickelectric
and removed request for
patrickelectric
Williangalvani
force-pushed
the
model_overrides
branch
from
5853437 to
e2a4d4e
Compare
patrickelectric
requested changes
Feb 9, 2023
core/frontend/src/components/vehiclesetup/viewers/VehicleViewer.vue
Outdated
Show resolved
Hide resolved
ES-Alexander
approved these changes
Feb 10, 2023
Collaborator
ES-Alexander
left a comment
ES-Alexander
left a comment
There was a problem hiding this comment.
Looks ok to me, but I haven't extensively reviewed the code - I just want the feature :-)
Williangalvani
force-pushed
the
model_overrides
branch
from
e2a4d4e to
82b8d4d
Compare
Williangalvani
force-pushed
the
model_overrides
branch
from
82b8d4d to
477588f
Compare
Williangalvani
force-pushed
the
model_overrides
branch
from
477588f to
a9156e1
Compare
patrickelectric
approved these changes
Feb 13, 2023
16 tasks
ES-Alexander
added
docs-minimal
ES-Alexander
added
docs-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as a bonus commit, this fixed #1455