Telemetry log endpoint feature#84
Closed
landswellsong wants to merge 1 commit intobluenviron:mainfrom
Closed
Conversation
Member
|
Hello, this is OK but i'd like to move the log reader and writer inside |
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
to bluenviron/gomavlib
that referenced
this pull request
Mar 3, 2025
aler9
added a commit
that referenced
this pull request
Mar 6, 2025
2 tasks
Member
|
replaced by #106 |
aler9
added a commit
that referenced
this pull request
Mar 6, 2025
aler9
added a commit
that referenced
this pull request
Mar 11, 2025
aler9
added a commit
that referenced
this pull request
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an option to specify
tlog:endpoints that would write incoming traffic in a Mavlink Logfile.I thought it might be useful to make a PR of. It seems to be working alright, but my Go is very rusty (pun not intended) so I think the quality of the code can be improved.
In particular things I'm not very sure about:
Read()method like that? Ideally I'd pause that goroutine until the exit sequence, but I'm not very sure how to do that properly without alteringgomavlibtoo much.gomavlibissue writes in full packets? There seem to be some buffering involved, but I'm not entirely sure how Go's buffering operates. Currently my code assumes that the bytes to write is a whole single packet.