This repository was archived by the owner on Jan 30, 2025. It is now read-only.
update solutions module and solutions test exclusion#1469
Merged
circlecube merged 1 commit intodevelopfrom Dec 11, 2024
Merged
Conversation
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
update/solutions-module-and-test-exclusion
|
| Run status |
|
| Run duration | 37m 23s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
32
|
Skipped
|
0
|
Passing
|
414
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
vendor/newfold-labs/wp-module-solutions/tests/cypress/integration/solutions-app.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| My Plugins and Tools in Plugin App > My Plugins & Tools displays with Solution |
Test Replay
Screenshots
Video
|
|
vendor/newfold-labs/wp-module-onboarding/tests/cypress/integration/2-general-onboarding-flow/basic-info.cy.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Basic Info Page > Check Drawer Activity |
Test Replay
Screenshots
Video
|
|
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
update/solutions-module-and-test-exclusion
|
| Run status |
|
| Run duration | 32m 49s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
1
|
|
Pending
|
32
|
|
Skipped
|
0
|
|
Passing
|
415
|
| View all changes introduced in this branch ↗︎ | |
wpscholar
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the solutions module and the cypress text exclusion to account for the test files being split. Splitting the files so that the Jetpack dependent test is in it's own file. Now when jetpack is unavailable in the env, we can still run the other solutions tests.
Type of Change
Checklist
Further comments