Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

remove performance module alias#1374

Merged
circlecube merged 2 commits intodevelopfrom
update/performance-module-alias
Oct 25, 2024
Merged

remove performance module alias#1374
circlecube merged 2 commits intodevelopfrom
update/performance-module-alias

Conversation

@circlecube
Copy link
Copy Markdown
Member

@circlecube circlecube commented Oct 25, 2024

Proposed changes

Now that onboarding has updated the performance module version in its requirements we can remove the alias to the 2.x major update.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
remove performance module alias
7f396a8 
now that onboarding updated the performance module version in it's requirements we can remove the alias to the 2.x major update.
@circlecube circlecube self-assigned this Oct 25, 2024
@cypress
Copy link
Copy Markdown

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11286

Run Properties:  status check passed Passed #11286  •  git commit ee2d1b7750 ℹ️: Merge 7f396a8fb621fa14d724603246fab000f6cff3d7 into 56a55497e6997e4624dbef7da0ea...
Project Bluehost Brand Plugin
Branch Review update/performance-module-alias
Run status status check passed Passed #11286
Run duration 27m 19s
Commit git commit ee2d1b7750 ℹ️: Merge 7f396a8fb621fa14d724603246fab000f6cff3d7 into 56a55497e6997e4624dbef7da0ea...
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@cypress
Copy link
Copy Markdown

cypress bot commented Oct 25, 2024

Bluehost Brand Plugin    Run #11285

Run Properties:  status check passed Passed #11285  •  git commit 7f396a8fb6: remove performance module alias
Project Bluehost Brand Plugin
Branch Review update/performance-module-alias
Run status status check passed Passed #11285
Run duration 30m 03s
Commit git commit 7f396a8fb6: remove performance module alias
Committer Evan Mullins
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

@circlecube
Merge branch 'develop' into update/performance-module-alias
c741284 
* develop:
  remove my products module

# Conflicts:
#	composer.lock
@circlecube circlecube merged commit e50c494 into develop Oct 25, 2024
@circlecube circlecube deleted the update/performance-module-alias branch October 25, 2024 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abhijitb abhijitb Awaiting requested review from abhijitb

@wpalani wpalani Awaiting requested review from wpalani

1 more reviewer

@wpscholar wpscholar wpscholar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@circlecube circlecube

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@circlecube @wpscholar