Merging this PR will not alter performance

Summary

✅ 173 untouched benchmarks

_{Comparing datnguyencse:reuse-state-cache-across-block (393719c) with main (d06f638)}

Was closed accidentally as it was tagged in a different PR that got merged. Sorry about that

Change does not make sense, all statuses represent known storage so it does not make sense to fetch it from database.

1. How do you see that it is a wrong value. Assumption is that all storage values are inside cache (as account got created or destroyed inside the block), and that cache will not evict values from it.

2. Should be safe, and iirc it was used inside reth for initial sync to run one instance accross blocks. But would test this to be sure

Thanks for the explanation.

In the case of reth, they reuse state to sync a historical branch of blocks, then merge transitions and extract the bundle only at the last block. In that workflow, reusing state does not cause issues.

However, in our case (live sync), bundles and transitions are merged after each block. Under this model, reusing the state (or the state cache) across blocks can lead to incorrect values and errors.

Hopefully, you’ll be able to take this difference into account when testing and verifying the behavior. Reusing state between blocks is extremely important for correctness in live sync scenarios.

Thank you very much for your time and for looking into this.