perf: add Display for HaltReason and OutOfGasError#3265
Merged
rakita merged 1 commit intobluealloy:mainfrom Dec 31, 2025
Merged
perf: add Display for HaltReason and OutOfGasError#3265rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
Contributor
Author
|
BTW This was inconsistent with InvalidTransaction and InvalidHeader which already have Display impls. |
CodSpeed Performance ReportMerging #3265 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Display implementations for HaltReason and OutOfGasError to improve error messages.
Previously these types only had Debug, so errors showed up as
Halt { reason: OutOfGas(Basic) }instead of readable messages like "out of gas".