refactor(revme): consolidate find_all_json_tests in dir_utils#3262
Merged
rakita merged 1 commit intobluealloy:mainfrom Jan 9, 2026
Merged
refactor(revme): consolidate find_all_json_tests in dir_utils#3262rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #3262 will degrade performance by 3.71%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
sorry, maybe i shouldn't close my PR, because i'm not sure my changes could degrade performance. |
rakita
reviewed
Jan 5, 2026
Eliminate code duplication by consolidating three separate implementations of find_all_json_tests into a single shared implementation in the dir_utils module. This reduces maintenance burden and ensures consistent behavior across blockchaintest and statetest commands.
letmehateu
force-pushed
the
code-duplication
branch
from
c9e7709 to
978a227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates code duplication by consolidating three implementations of
find_all_json_testsinto a single, complete implementation in the shareddir_utilsmodule.