refactor(handler): eliminate code duplication in transaction validation#3243
Merged
rakita merged 4 commits intobluealloy:mainfrom Dec 22, 2025
Merged
refactor(handler): eliminate code duplication in transaction validation#3243rakita merged 4 commits intobluealloy:mainfrom
rakita merged 4 commits intobluealloy:mainfrom
Conversation
CodSpeed Performance ReportMerging #3243 will not alter performanceComparing Summary
|
rakita
reviewed
Dec 22, 2025
crates/handler/src/validation.rs
Outdated
Comment on lines
66
to
67
| fn validate_priority_fee_for_tx<CTX: ContextTr>( | ||
| context: &CTX, |
Member
There was a problem hiding this comment.
You could do it with TX in place of CTX
Contributor
Author
There was a problem hiding this comment.
You could do it with TX in place of CTX
Changed, thank you
rakita
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a helper function
validate_priority_fee_for_txto reduce code duplication. The function is used for Eip1559, Eip4844, and Eip7702 transaction types, eliminating three identical calls with the same parameters.