fix(statetest): use spec-aware blob base fee update fraction#3210
Merged
rakita merged 1 commit intobluealloy:mainfrom Dec 8, 2025
Merged
fix(statetest): use spec-aware blob base fee update fraction#3210rakita merged 1 commit intobluealloy:mainfrom
rakita merged 1 commit intobluealloy:mainfrom
Conversation
The state test runner was hardcoding BLOB_BASE_FEE_UPDATE_FRACTION_CANCUN (3,338,477) instead of using the spec-aware value from CfgEnv. This caused consensus divergence with geth on Prague/Osaka blob transaction tests. Changes: - Modified block_env() to use cfg.blob_base_fee_update_fraction() which returns the correct value based on spec (Cancun: 3338477, Prague: 5007716) - Updated runner.rs to pass mutable cfg reference as required by the API - Added comprehensive unit tests verifying correct blob fee calculation for Cancun, Prague, and Osaka forks With excess_blob_gas=0x240000 and maxFeePerBlobGas=0x01: - Cancun fraction (3338477): blob_price = 2, tx FAILS (insufficient fee) - Prague fraction (5007716): blob_price = 1, tx SUCCEEDS 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CodSpeed Performance ReportMerging #3210 will not alter performanceComparing Summary
|
rakita
approved these changes
Dec 8, 2025
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm,
blob_base_fee_update_fraction should be & but this is PR for later
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state test runner was hardcoding BLOB_BASE_FEE_UPDATE_FRACTION_CANCUN (3,338,477) instead of using the spec-aware value from CfgEnv. This caused consensus divergence with geth on Prague/Osaka blob transaction tests.
Changes:
With excess_blob_gas=0x240000 and maxFeePerBlobGas=0x01:
🤖 Generated with Claude Code