feat: add retry_push_count option to expose retry-push CLI options#91
Merged
gmpinder merged 1 commit intoblue-build:mainfrom Sep 2, 2025
Merged
feat: add retry_push_count option to expose retry-push CLI options#91gmpinder merged 1 commit intoblue-build:mainfrom
gmpinder merged 1 commit intoblue-build:mainfrom
Conversation
gmpinder
previously approved these changes
Aug 21, 2025
Member
|
Thanks for the contribution! |
This comment was marked as resolved.
This comment was marked as resolved.
It's reasonable common for the image pushing step to fail in CI due to transient network issues, so it makes sense to expose the `--retry-push` and `--retry-count` options in the GitHub action. This adds a `retry_push_count` option to the action that defaults to 0, and if set to be nonzero, it enables `--retry-push` and passes the retry count to the CLI. I also did a bit of minor cleanup of the action: * Updated actions/checkout to v5.0.0. * Added `persist-credentials: false` to actions/checkout for security, per Zizmor recommendation. * Converted direct template expansions (which are potentially vulnerable to code injection attacks) into environment variables. * Quoted shell variables to prevent unintended shell splitting. Signed-off-by: Daniel Hast <[email protected]>
HastD
changed the title
gmpinder
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's reasonably common for the image pushing step to fail in CI due to transient network issues, so it makes sense to expose the
--retry-pushand--retry-countoptions in the GitHub action. This adds aretry_push_countoption to the action that defaults to 0, and if set to be nonzero, it enables--retry-pushand passes the retry count to the CLI.I also did a bit of minor cleanup of the action:
persist-credentials: falseto actions/checkout for security, per Zizmor recommendation.