Skip to content

feat: rechunk support#69

Merged
xynydev merged 9 commits intomainfrom
rechunk
Dec 3, 2024
Merged

feat: rechunk support#69
xynydev merged 9 commits intomainfrom
rechunk

Conversation

@xynydev
Copy link
Copy Markdown
Member

@xynydev xynydev commented Dec 2, 2024

(also some autoformatting)

@xynydev
Copy link
Copy Markdown
Member Author

xynydev commented Dec 2, 2024

I'm unable to get this working, but not sure what the issue is. Maybe someone else can figure this out?
https://github.com/xynydev/linuXYZ/actions/runs/12124482608/job/33802828924

@fiftydinar
Copy link
Copy Markdown
Collaborator

fiftydinar commented Dec 2, 2024

Ideally, sudo should only be running when rechunk is enabled, otherwise non-root execution

@xynydev
Copy link
Copy Markdown
Member Author

xynydev commented Dec 2, 2024

In principle I agree, but I'm not sure what the actual security drawbacks would be on GitHub Actions. Getting this working would be my first priority.

@fiftydinar
Copy link
Copy Markdown
Collaborator

@fiftydinar
Copy link
Copy Markdown
Collaborator

fiftydinar commented Dec 2, 2024

Maybe you need to append BUILD_OPTS array, rather than declare it as new?

hmm, nah

@gmpinder
Copy link
Copy Markdown
Member

gmpinder commented Dec 2, 2024

Keep in mind we'll also need to have a pull request quest for bumping the image version to v0.9, or we can do it in this one

@gmpinder
Copy link
Copy Markdown
Member

gmpinder commented Dec 3, 2024

@fiftydinar
Copy link
Copy Markdown
Collaborator

Ok I think I got this working https://github.com/gmpinder/testos/actions/runs/12131970193/job/33825026568

I confirm it works.

Version is changed from yyyymmdd format to yymmdd, that's Rechunk behavior, so it works.

I approve this.

fiftydinar
fiftydinar previously approved these changes Dec 3, 2024
@xynydev
Copy link
Copy Markdown
Member Author

xynydev commented Dec 3, 2024

I approve this too, but I can't because I started the PR, so one of you should do a final look-over an approve.

@xynydev xynydev merged commit 848d8e8 into main Dec 3, 2024
@xynydev xynydev deleted the rechunk branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants