feat: allow providing options to bluebuild build command#63
Merged
xynydev merged 4 commits intoblue-build:mainfrom Nov 11, 2024
Merged
feat: allow providing options to bluebuild build command#63xynydev merged 4 commits intoblue-build:mainfrom
bluebuild build command#63xynydev merged 4 commits intoblue-build:mainfrom
Conversation
xynydev
previously approved these changes
Nov 10, 2024
Member
|
Thanks a lot! This is a fantastic PR! 💙 I'll let this be open for a moment in case other maintaines want to have a say, but will do a full merge + release tomorrow at the latest. |
gmpinder
requested changes
Nov 10, 2024
xynydev
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a
build_optsinput along with some basic validation to ensure that duplicate options are not passed tobuildbuild build.bluebuild builderrors should mention arguments explicitly added by the user as being the problem. So they should not be caught completely unawares that --nonexistent-arg is the problem.-por--pushsince the action provides that option by default.