feat: support rechunking with build-chunked-oci#610
feat: support rechunking with build-chunked-oci#610gmpinder merged 4 commits intoblue-build:mainfrom
Conversation
|
The code looks really good! Now if you can add a test case for a single arch and multi arch build using this? You can crib from the |
HastD
force-pushed
the
build-chunked-oci
branch
from
5d6540b to
adf3f88
Compare
|
@gmpinder Added integration test cases as requested. |
|
Some of the tests might be failing cause of permission issues. The chunked oci ones I think are failing cause of the |
|
@gmpinder I don't think that "manifest unknown" error happening in some of the tests is due to my changes; I saw the same thing yesterday in a PR build for secureblue that doesn't change anything except updating the CLI to v0.9.25 (from v0.9.24) and adding the |
HastD
force-pushed
the
build-chunked-oci
branch
from
adf3f88 to
160d508
Compare
Interesting. The integration tests didn't catch that. |
|
Yeah so going from the most recent test logs for this PR, it looks like rechunking with build-chunked-oci is working fine (which makes sense, I tested it locally), but then something afterward (in code I didn't change) isn't working. |
Add support for rechunking images with `rpm-ostree compose build-chunked-oci`. This is available in the CLI with the `--build-chunked-oci` option, with an optional `--max-layers` argument to specify the maximum number of layers in the rechunked image.
HastD
force-pushed
the
build-chunked-oci
branch
from
160d508 to
2805f4a
Compare
|
I'm working on trying to fix the manifest issue in #615. It appears this issue occurs outside of your changes too. |
|
Ok that change seemed to work. I'm going to update your branch real quick. |
2 participants
Add support for rechunking images with
rpm-ostree compose build-chunked-oci. This is available in the CLI with the--build-chunked-ocioption, with an optional--max-layersargument to specify the maximum number of layers in the rechunked image.