Skip to content

fix: Remove hard requirement for login creds to be able to push#187

Merged
gmpinder merged 4 commits intomainfrom
remove-cred-requirement
May 29, 2024
Merged

fix: Remove hard requirement for login creds to be able to push#187
gmpinder merged 4 commits intomainfrom
remove-cred-requirement

Conversation

@gmpinder
Copy link
Copy Markdown
Member

@gmpinder gmpinder self-assigned this May 29, 2024
Copy link
Copy Markdown
Contributor

@gerblesh gerblesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerblesh
Copy link
Copy Markdown
Contributor

looks like CI is having some hiccups but the PR looks solid

@gmpinder
Copy link
Copy Markdown
Member Author

looks like CI is having some hiccups but the PR looks solid

Yeah that's been happening recently and I'm not sure why. Might be time to rotate the earthly satellite.

@gmpinder gmpinder enabled auto-merge (squash) May 29, 2024 02:56
@gmpinder gmpinder disabled auto-merge May 29, 2024 02:56
@gmpinder gmpinder merged commit 9dd1ec9 into main May 29, 2024
@gmpinder gmpinder deleted the remove-cred-requirement branch May 29, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants