le/symbols as weak map keys #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acutmore
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Thank you @leoelm this is fantastic!
I've left just a few small comments. Feel free to IB me if want to chat over any of them in person/on a call.
Also feel free to post a link to the PR in the TypeScript contributors IB pchat if you'd like to share your progress.
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
…cript into le/symbols-as-weak-map-keys
acutmore
reviewed
Mar 31, 2023
Signed-off-by: Leo Elmecker <[email protected]>
Signed-off-by: Leo Elmecker <[email protected]>
acutmore
reviewed
Apr 6, 2023
acutmore
approved these changes
Apr 6, 2023
leoelm
added a commit
that referenced
this pull request
Jun 1, 2023
Support symbols in WeakMap, WeakSet, WeakRef and FinalizationRegistry Signed-off-by: Leo Elmecker <[email protected]>
leoelm
added a commit
that referenced
this pull request
Jun 8, 2023
Support symbols in WeakMap, WeakSet, WeakRef and FinalizationRegistry Signed-off-by: Leo Elmecker <[email protected]>
leoelm
added a commit
that referenced
this pull request
Jun 9, 2023
Support symbols in WeakMap, WeakSet, WeakRef and FinalizationRegistry Signed-off-by: Leo Elmecker <[email protected]>
dragomirtitian
pushed a commit
that referenced
this pull request
Aug 29, 2023
Signed-off-by: Leo Elmecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: microsoft#52534
Describe your changes
Add type support for
symboltoWeakMap,WeakSet,WeakRefandFinalizationRegistry. This has been achieved by retrospectively introducing the interfaceWeakKeyTypesStorewhich then composes the typeWeakKeyTypes. In previous es versions this custom type will only supportobject, however expanding the interface to also supportsymbolhas been done inES2023.Testing performed
To test the feature addition,
WeakMap,WeakSet,WeakRefandFinalizationRegistryand all their member functions have been tested usingsymbolfor the relevant inputs to prove failure in versions preceding es2023 and show it to be working inES2023.