Fixing database error #238
Conversation
What is the reason of doing this change and changing the update logic ? As we know plugins_loaded is called on each page so this is really uncessary It is not enough to just address the real reason of this error? Changing CREATE IF NOT EXISTS TO CREATE should be sufficient. |
|
If only CREATE IF NOT EXISTS TO CREATE is changed it results in a new database related error. It seems to have to Using register_activation_hook() to fire blockonomics_create_table() resolved the error given in the image above. |
1 similar comment
|
If only CREATE IF NOT EXISTS TO CREATE is changed it results in a new database related error. It seems to have to Using register_activation_hook() to fire blockonomics_create_table() resolved the error given in the image above. |
This reverts commit c011eff.
|
Looking good. Will merge after some testing |
This PR is created to fix this error. I was able to recreate the error and has done some small changes in order to fix it.
There are mainly two things that have changed. The register_activation_hook() has been introduced. It is true that this is not called during an update. However, it seems to be necessary during plugin initiation.
$sql CREATE TABLE IF NOT EXISTS has been changed to CREATE TABLE. This is the way it is structured in the WordPress documentation. It seems to be the case that dbDelta() does not require IF NOT EXISTS, but will instead discern this itself.
As part of testing I've deleted, installed, upgraded the database, with and without orders. It seems to work as it should,
Please review this PR.