Skip to content

ci: per semver build metadata should be after +#971

Merged
kalvinnchau merged 1 commit intomainfrom
kalvin/hotfix/canary-semver
Jan 31, 2025
Merged

ci: per semver build metadata should be after +#971
kalvinnchau merged 1 commit intomainfrom
kalvin/hotfix/canary-semver

Conversation

@kalvinnchau
Copy link
Copy Markdown
Contributor

ci: fix semver build metadata

per: https://semver.org/#spec-item-10, build metadata should be after + and not .

❯ cargo build
error: invalid leading zero in pre-release identifier
 --> Cargo.toml:7:11
  |
7 | version = "1.0.3-canary.0020123"
  |           ^^^^^^^^^^^^^^^^^^^^^^
  |

vs

❯ cargo build
   Compiling goose v1.0.3-canary+0020123)
   Compiling goose-mcp v1.0.3-canary+0020123 

@kalvinnchau kalvinnchau merged commit 27e1ce7 into main Jan 31, 2025
@kalvinnchau kalvinnchau deleted the kalvin/hotfix/canary-semver branch January 31, 2025 02:10
michaelneale added a commit that referenced this pull request Jan 31, 2025
* main: (28 commits)
  ci: per semver build metadata should be after + (#971)
  fix: temp fix to make CI workflow pass (#970)
  chore: bump patch version to 1.0.3 (#967)
  fix: load shell automatically from env for GUI (#948)
  fix: update versions in release and canary workflows (#911)
  docs: fix typo, name (#963)
  docs: typo fix (#961)
  chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959)
  chore: remove o1-mini suggestion from UI add model view (#957)
  fix: missing field in request (#956)
  docs: update provider docs, fix rate limit link (#943)
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
  Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888)
  fix: improve configure process with error message (#919)
  docs: Goose on Windows via WSL (#901)
  fix: more graceful handling of missing usage in provider response (#907)
  ...
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants