Skip to content

fix: missing field in request#956

Merged
yingjiehe-xyz merged 1 commit intomainfrom
yingjiehe/improve
Jan 30, 2025
Merged

fix: missing field in request#956
yingjiehe-xyz merged 1 commit intomainfrom
yingjiehe/improve

Conversation

@yingjiehe-xyz
Copy link
Copy Markdown
Contributor

@yingjiehe-xyz yingjiehe-xyz commented Jan 30, 2025

Also improve the CLI configuration by providing default value for ollama host

Test:

CLI configuration with default value:

┌   goose-configure 
│
◇  What would you like to configure?
│  Configure Providers 
│
◇  Which model provider should we use?
│  Ollama 
│
●  OLLAMA_HOST is already configured
│  
◇  Would you like to update this value?
│  Yes 
│
◆  Enter new value for OLLAMA_HOST
│  http://localhost:11434 (default)
└  

without default value:

┌   goose-configure 
│
◇  What would you like to configure?
│  Configure Providers 
│
◇  Which model provider should we use?
│  Databricks 
│
●  DATABRICKS_HOST is already configured
│  
◇  Would you like to update this value?
│  Yes 
│
◆  Enter new value for DATABRICKS_HOST
│   
└ 

@yingjiehe-xyz yingjiehe-xyz requested a review from lily-de January 30, 2025 20:44
@yingjiehe-xyz yingjiehe-xyz merged commit a6e97b8 into main Jan 30, 2025
@yingjiehe-xyz yingjiehe-xyz deleted the yingjiehe/improve branch January 30, 2025 21:38
michaelneale added a commit that referenced this pull request Jan 30, 2025
* main:
  chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959)
  chore: remove o1-mini suggestion from UI add model view (#957)
  fix: missing field in request (#956)
  docs: update provider docs, fix rate limit link (#943)
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
michaelneale added a commit that referenced this pull request Jan 31, 2025
* main: (28 commits)
  ci: per semver build metadata should be after + (#971)
  fix: temp fix to make CI workflow pass (#970)
  chore: bump patch version to 1.0.3 (#967)
  fix: load shell automatically from env for GUI (#948)
  fix: update versions in release and canary workflows (#911)
  docs: fix typo, name (#963)
  docs: typo fix (#961)
  chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959)
  chore: remove o1-mini suggestion from UI add model view (#957)
  fix: missing field in request (#956)
  docs: update provider docs, fix rate limit link (#943)
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
  Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888)
  fix: improve configure process with error message (#919)
  docs: Goose on Windows via WSL (#901)
  fix: more graceful handling of missing usage in provider response (#907)
  ...
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants