fix: request payload for configuring o1 models, propagate errors#921
Merged
salman1993 merged 10 commits intomainfrom Jan 30, 2025
Merged
fix: request payload for configuring o1 models, propagate errors#921salman1993 merged 10 commits intomainfrom
salman1993 merged 10 commits intomainfrom
Conversation
wendytang
force-pushed
the
wtang/o1_request
branch
from
0a3beec to
1cd26bd
Compare
Contributor
|
seems like starting session | provider: openai model: o1-mini
logging to /Users/kalvin/.config/goose/sessions/HUPEpH1s.jsonl
Goose is running! Enter your instructions, or try asking what goose can do.
( O)> what tools do you have
◒ Jazzing up algorithms... 2025-01-30T00:11:53.602782Z ERROR goose::agents::truncate: Error: Request failed: 404 Not Found - Some(Object {"error": Object {"code": Null, "message": String("tools is not supported in this model. For a list of supported models, refer to https://platform.openai.com/docs/guides/function-calling#models-supporting-function-calling."), "param": Null, "type": String("invalid_request_error")}})
at crates/goose/src/agents/truncate.rs:256
Ran into this error: Request failed: 404 Not Found - Some(Object {"error": Object {"code": Null, "message": String("tools is not supported in this model. For a list of supported models, refer to https://platform.op
enai.com/docs/guides/function-calling#models-supporting-function-calling."), "param": Null, "type": String("invalid_request_error")}}).their doc link in the response also doesn't point me anywhere valid, since that's the case do we want too keep any o1-mini specific logic? |
Author
|
@kalvinnchau I think you're right that o1-mini doesn't support tool calling https://community.openai.com/t/when-o1-o1-preview-or-o1-mini-supports-tools/1102822 |
salman1993
reviewed
Jan 30, 2025
salman1993
reviewed
Jan 30, 2025
Author
|
Adds docs about o1-mini and o1-preview. there is only one o1 model currently aliased to v2024-12-17 |
wendytang
force-pushed
the
wtang/o1_request
branch
from
e2015ea to
e595b11
Compare
* origin/main: Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888)
wendytang
force-pushed
the
wtang/o1_request
branch
from
e595b11 to
7130bf2
Compare
salman1993
approved these changes
Jan 30, 2025
salman1993
added a commit
that referenced
this pull request
Jan 30, 2025
* origin/main: fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) feat: rm uv.lock cause it points to square artifactory (#917) feat: Update issue templates for bug report for goose (#913) fix: post endpoint url on sse endpoint event (#900)
michaelneale
added a commit
that referenced
this pull request
Jan 30, 2025
* main: chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959) chore: remove o1-mini suggestion from UI add model view (#957) fix: missing field in request (#956) docs: update provider docs, fix rate limit link (#943) fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921)
michaelneale
added a commit
that referenced
this pull request
Jan 31, 2025
* main: (28 commits) ci: per semver build metadata should be after + (#971) fix: temp fix to make CI workflow pass (#970) chore: bump patch version to 1.0.3 (#967) fix: load shell automatically from env for GUI (#948) fix: update versions in release and canary workflows (#911) docs: fix typo, name (#963) docs: typo fix (#961) chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959) chore: remove o1-mini suggestion from UI add model view (#957) fix: missing field in request (#956) docs: update provider docs, fix rate limit link (#943) fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) ...
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
Co-authored-by: Salman Mohammed <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Co-authored-by: Salman Mohammed <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temperatureandmax_tokensin o1 seriesProviderError propogation:
Test plan: