fix: more graceful handling of missing usage in response#907
Merged
ahau-square merged 4 commits intomainfrom Jan 30, 2025
Merged
fix: more graceful handling of missing usage in response#907ahau-square merged 4 commits intomainfrom
ahau-square merged 4 commits intomainfrom
Conversation
Contributor
|
lgtm! for anthropic and google, we can add the logging too |
salman1993
approved these changes
Jan 29, 2025
Contributor
salman1993
left a comment
salman1993
left a comment
There was a problem hiding this comment.
nit: can we make the PR title conventional commit fix: ..
ahau-square
changed the title
salman1993
added a commit
that referenced
this pull request
Jan 30, 2025
* origin/main: fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) feat: rm uv.lock cause it points to square artifactory (#917) feat: Update issue templates for bug report for goose (#913) fix: post endpoint url on sse endpoint event (#900)
michaelneale
added a commit
that referenced
this pull request
Jan 31, 2025
* main: (28 commits) ci: per semver build metadata should be after + (#971) fix: temp fix to make CI workflow pass (#970) chore: bump patch version to 1.0.3 (#967) fix: load shell automatically from env for GUI (#948) fix: update versions in release and canary workflows (#911) docs: fix typo, name (#963) docs: typo fix (#961) chore: remove gpt-3.5-turbo UI suggestion, as it is deprecated (#959) chore: remove o1-mini suggestion from UI add model view (#957) fix: missing field in request (#956) docs: update provider docs, fix rate limit link (#943) fix: clarify linux cli install only (#927) feat: update ui for ollama host (#912) feat: add CONFIGURE=false option in install script (#920) fix: truncation agent token calculations (#915) fix: request payload for o1 models (#921) Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888) fix: improve configure process with error message (#919) docs: Goose on Windows via WSL (#901) fix: more graceful handling of missing usage in provider response (#907) ...
ahau-square
added a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a transient issue with usage failing to be returned on OpenRouter with the Anthropic model: #899 (comment)
According to their documentation, usage should always be returned for non-streaming calls, but that appears not to be the case. This PR allows more graceful failing and returning default usage with None fields in case that happens. It also does the same for the other providers so that getting the 'usage' won't cause a completion to fail.