Skip to content

fix: post endpoint url on sse endpoint event#900

Merged
salman1993 merged 1 commit intomainfrom
sm/fix-sse-endpoint
Jan 29, 2025
Merged

fix: post endpoint url on sse endpoint event#900
salman1993 merged 1 commit intomainfrom
sm/fix-sse-endpoint

Conversation

@salman1993
Copy link
Copy Markdown
Contributor

@salman1993 salman1993 commented Jan 29, 2025 •
edited
Loading

should fix: #893

works for these:

Base: http://localhost:8080/sse
Relative: /messages/?session=x2y3z
Expected: http://localhost:8080/messages/?session=x2y3z
-------------------------------
Base: http://localhost:8080/mcp/sse
Relative: /mcp/messages/xyz
Expected: http://localhost:8080/mcp/messages/xyz
-------------------------------
Base: http://localhost:8080/mcp/sse
Relative: messages/xyz
Expected: http://localhost:8080/mcp/messages/xyz
-------------------------------
Base: http://example.com/api/sse
Relative: /messages/xyz
Expected: http://example.com/messages/xyz
-------------------------------
Base: http://example.com/api/sse
Relative: messages/xyz
Expected: http://example.com/api/messages/xyz
-------------------------------

@salman1993 salman1993 merged commit 407cebf into main Jan 29, 2025
salman1993 added a commit that referenced this pull request Jan 30, 2025
@salman1993
Merge remote-tracking branch 'origin/main' into ldelalande/bump-versions
6b7081c 
* origin/main:
  fix: clarify linux cli install only (#927)
  feat: update ui for ollama host (#912)
  feat: add CONFIGURE=false option in install script (#920)
  fix: truncation agent token calculations (#915)
  fix: request payload for o1 models (#921)
  Update SupportedEnvironments.js so others don't get confused on why they can not open the macos app on x86 (#888)
  fix: improve configure process with error message (#919)
  docs: Goose on Windows via WSL (#901)
  fix: more graceful handling of missing usage in provider response (#907)
  feat: rm uv.lock cause it points to square artifactory (#917)
  feat: Update issue templates for bug report for goose (#913)
  fix: post endpoint url on sse endpoint event (#900)
@yingjiehe-xyz yingjiehe-xyz deleted the sm/fix-sse-endpoint branch February 5, 2025 21:10
ahau-square pushed a commit that referenced this pull request May 2, 2025
@salman1993
fix: post endpoint url on sse endpoint event (#900)
b7948ef
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
@salman1993
fix: post endpoint url on sse endpoint event (block#900)
2cd9ff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalvinnchau kalvinnchau kalvinnchau approved these changes

@wendytang wendytang Awaiting requested review from wendytang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remote extension: invalid SSE POST endpoint discovered

2 participants

@salman1993 @kalvinnchau