Parse streaming override as bool

resolve_config reads *_STREAMING with get_param::<String>(), but config/env parsing can return native booleans for values like TANZU_AI_STREAMING=false. In that case deserialization to String fails, .ok() drops the override, and the code falls back to the default ("true" in tanzu.json), so users cannot disable streaming via normal environment variable syntax.

Useful? React with 👍 / 👎.

Good catch. Fixed — resolve_config now tries get_param:: first, then falls back to get_param::, so both YAML string "true" and native bool true are handled correctly.

Normalize boolean config before calling toLowerCase

The form assumes getRenderValue() always returns a string, but read() can yield booleans (for example when config/env contains unquoted true/false). When that happens, getRenderValue(parameter) can be a boolean and toLowerCase() throws at runtime, breaking provider configuration UI for those users.

Useful? React with 👍 / 👎.

Good catch. Fixed — getBooleanValue now wraps the value with String() before calling toLowerCase(), handling both string and native boolean returns from config.

Preserve secret-read errors when loading API key

This map_err(|_| ...) rewrites every get_secret failure into "API key is not set", including non-NotFound cases like keyring access failures or deserialization errors. In those cases users get a misleading remediation path and lose the real root cause, which makes provider setup/debugging much harder. Please only translate NotFound into this friendly message and propagate other error variants unchanged.

Useful? React with 👍 / 👎.

Good point. Fixed — map_err now matches on ConfigError::NotFound to give the friendly "not set" message, and propagates all other error variants (keyring failures, deserialization errors, etc.) with their original context.

Exit script when fallback installer build fails

When electron-forge make fails, the fallback make --targets=@electron-forge/maker-squirrel is executed but its exit code is never checked. If that fallback also fails (e.g., missing maker dependency), the script still continues to "Build Complete" and exits successfully, which can silently produce no installer in automation or manual release workflows.

Useful? React with 👍 / 👎.

Good catch. Fixed — the fallback build now checks LASTEXITCODE and exits with error if it also fails.

Preserve false values for boolean provider toggles

Boolean config values read as native false get collapsed to an empty render value and then this fallback path applies the default, so a stored false (for example TANZU_AI_STREAMING=false from config/env) is shown as checked and can be written back as true on submit. This makes the new streaming toggle unreliable for users who explicitly disabled it.

Useful? React with 👍 / 👎.

Good catch — native bool false was indeed falsy and got collapsed to empty string. Fixed by using explicit String() conversion on serverValue instead of the || operator.

Fail fast when API type generation exits non-zero

The script does not check $LASTEXITCODE after pnpm run generate-api, so a generator failure is treated as success and the build continues into packaging/installer steps with stale or missing generated API types. This can silently produce broken release artifacts in CI or manual release runs.

Useful? React with 👍 / 👎.

Fixed — added LASTEXITCODE check after generate-api step.

Use lowercase goose in docs copy

documentation/AGENTS.md requires the product name to always be written as lowercase goose within the documentation tree, but this new guide introduces Goose in user-facing text (and repeats it in multiple places), which violates the documented style contract for this directory and should be normalized before merge.

Useful? React with 👍 / 👎.

Preserve explicit false for boolean provider toggles

This default branch makes an empty render value fall back to the parameter default, so users with an explicit false value can be shown true and have that written back on submit. Fresh evidence: loadConfigValues still gates assignment with if (configValue), so when /config/read returns JSON false (for example TANZU_AI_STREAMING: false), the stored value is dropped before the new boolean rendering path runs, and this fallback re-enables the toggle.

Useful? React with 👍 / 👎.

Use lowercase goose in docs per style guide

documentation/AGENTS.md requires the product name to be written as lowercase goose throughout the documentation tree, but this new guide uses Goose in user-facing copy (for example, in the prerequisites line here, and again later in the file). This violates the documented docs standard and should be normalized before merge.

Useful? React with 👍 / 👎.