Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6b77bbe93
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| run: | | ||
| cd ui | ||
| npm ci | ||
| pnpm install --frozen-lockfile |
There was a problem hiding this comment.
Running pnpm install --frozen-lockfile at ui/ now installs the entire workspace, which includes ui/desktop where engines requires Node ^24.10.0 and pnpm >=10.30.0 (ui/desktop/package.json lines 6-9). In this workflow we still pin Node 20 and pnpm 9, so this step fails with ERR_PNPM_UNSUPPORTED_ENGINE before any package build/publish can run; this is a regression introduced by switching from npm ci to workspace-wide pnpm install.
Useful? React with 👍 / 👎.
* origin/main: fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
* main: Fix user message text silently dropped when message contains both text and image (#8071) fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
* origin/main: Fix user message text silently dropped when message contains both text and image (#8071) fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
2 participants
Fixes an issue in running npm publishing https://github.com/block/goose/actions/runs/23505976986/job/68417523609
https://github.com/block/goose/actions/runs/23507581639/job/68425026544 was a test build on a branch which was properly blocked from running the release, but also didn't fully exercise the rest of the job.
I suspect the pnpm switch in this PR will clear the issue in the first linked build, and we'll see if there is anything else.