fix: iteration on the publish-npm workflow#8087
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67feac6b4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
alexhancock
force-pushed
the
alexhancock/publish-npm-fix-and-dry-run
branch
from
67feac6 to
1582346
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15823461df
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/publish-npm.yml
Outdated
| environment: | ||
| name: npm-production-publishing | ||
| url: https://www.npmjs.com/org/block |
There was a problem hiding this comment.
With the environment configured as documented (Deployment branches: main), putting environment: npm-production-publishing on the entire release job causes GitHub to block workflow_dispatch runs from non-main branches before any steps execute. That means the new dry-run path cannot actually run on feature branches (the job is denied before Dry run summary), so this change prevents the pre-merge validation flow it introduces.
Useful? React with 👍 / 👎.
alexhancock
force-pushed
the
alexhancock/publish-npm-fix-and-dry-run
branch
from
1582346 to
161861e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 161861e5fd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| environment: | ||
| name: npm-production-publishing | ||
| url: https://www.npmjs.com/org/block |
There was a problem hiding this comment.
Define environment on the release job instead of this step, because GitHub Actions does not apply deployment environments at step scope. With it here, the workflow either fails validation (Unexpected value 'environment') or runs without attaching npm-production-publishing, so the protected NPM_PUBLISH_TOKEN environment secret is not provided to changesets/action and main-branch publishes cannot proceed as intended.
Useful? React with 👍 / 👎.
* origin/main: fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
* main: Fix user message text silently dropped when message contains both text and image (#8071) fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
* origin/main: Fix user message text silently dropped when message contains both text and image (#8071) fix: use pnpm when publishing (#8092) Alexhancock/publish npm file format fix (#8091) fix: iteration on the publish-npm workflow (#8087) chore: ignore unmaintained warning for proc-macro-error (#8084) chore: clean up stray recipe.yaml (#8086) chore(release): bump version to 1.29.0 (minor) (#8088) Update lockfile references (#8085) Fix version bump (#8083) Add a code review step which uses a short-lived provider token (#7932)
2 participants
Fixes an issue with artifact copying, and adds a dry-run mode we can use to verify this workflow before merge