fix(desktop): fullscreen header bar + always-visible close controls by aharvard · Pull Request #8033 · block/goose

aharvard · 2026-03-20T14:19:45Z

Summary

Adds a dedicated fullscreen header bar for MCP Apps and ensures close/exit controls are always accessible in fullscreen and PiP modes — even when the app didn't declare display mode support.

Changes

`useDisplayMode.ts`

Added appTitle state, extracted from appCapabilities.title during ui/initialize
Exposed appTitle in the hook's return value
Added debug logging for ui/initialize and ui/request-display-mode messages

`McpAppRenderer.tsx`

Fullscreen header bar — new dedicated 48px header that sits outside the iframe
- Three-column flexbox: spacer | center-aligned title | controls (PiP + close)
- Uses theme-aware colors (text-text-secondary, bg-background-primary, border-border-primary)
- Draggable region for Electron window movement; buttons retain individual no-drag
- Close button always visible — no hover/opacity gating
Title fallback chain: appTitle (from ui/initialize) → humanizeExtensionName(extensionName) → "App"
Container restructured for fullscreen — flex flex-col so header + content stack vertically, content area gets flex-1 min-h-0
contentRef — ResizeObserver moved from containerRef → contentRef so apps get accurate containerDimensions excluding the header height
showControls — added || isFullscreen || isPip so controls render even when the app didn't declare display mode support
Fullscreen controls moved from floating overlay to the header bar; renderDisplayModeControls() no longer renders in fullscreen mode

Testing

Tested with MCP App Bench inspectors (all display mode variants)
Verified title displays correctly from appCapabilities.title
Verified fallback to humanized extension name when no title provided
Verified close button is always accessible in both fullscreen and PiP
Verified PiP close works when app sends ui/request-display-mode without declaring modes

- Add dedicated 48px fullscreen header with centered title, PiP + close controls - Title fallback: appTitle (from ui/initialize) → humanizeExtensionName → 'App' - Extract appTitle from appCapabilities.title in ui/initialize - Restructure fullscreen container with flex-col layout (header + content) - Move ResizeObserver to contentRef so apps get dimensions excluding header - showControls renders even when app didn't declare fullscreen (|| isFullscreen) - Header uses no-drag class, theme-aware colors, always-visible close button - Add debug logging for ui/initialize and ui/request-display-mode Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

…re display modes showControls now includes || isPip so the close button renders when in PiP mode, matching the existing || isFullscreen pattern. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

Remove no-drag from the header container so the title bar area acts as a window drag handle. Buttons retain their individual no-drag classes. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

…eExtensionName Replace the duplicate humanizeExtensionName function with the existing formatExtensionName from ExtensionList. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

aharvard · 2026-03-20T14:33:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1a0bf9df9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/McpApps/McpAppRenderer.tsx

…button-always-visible

Signed-off-by: Douwe Osinga <[email protected]>

DOsinga

Looks good — just removed the two debug console.log statements from useDisplayMode.ts.

In PiP mode, contentRef does not get flex-1 so it sizes to its scroll-content height rather than the visible 400x300 viewport. This caused containerDimensions.height to report the wrong value for MCP apps making layout decisions based on available space. Revert to observing containerRef so the ResizeObserver reports the actual visible viewport dimensions in all display modes. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdf34b3a86

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/McpApps/McpAppRenderer.tsx

In fullscreen mode, the 48px header is inside containerRef, so the ResizeObserver reports the full viewport height. Subtract FULLSCREEN_HEADER_HEIGHT so containerDimensions.height reflects the actual space available for app content, preventing apps from rendering too tall and clipping behind the header. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5f7783803

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/McpApps/useDisplayMode.ts

ui/desktop/src/components/McpApps/McpAppRenderer.tsx

The ui/initialize request carries the app's identity in params.clientInfo.name, not caps.title or params.title which don't exist in the spec. This was causing appTitle to never be set, so the fullscreen header always fell back to the extension name. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

isFillsViewport is true for both fullscreen and standalone, but the 48px header is only rendered in fullscreen mode. Using isFullscreen instead so standalone apps get the correct containerDimensions.height. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8ad3f5ad7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/McpApps/useDisplayMode.ts

Remove non-spec appInfo and capabilities fields from the handshake. The spec defines clientInfo and appCapabilities as the correct fields. Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be84106345

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ui/desktop/src/components/McpApps/useDisplayMode.ts

Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33204b02dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

crates/goose-mcp/src/autovisualiser/templates/assets/mcp-app-bridge.js

…lock#8033) Signed-off-by: Andrew Harvard <[email protected]> Signed-off-by: Douwe Osinga <[email protected]> Co-authored-by: Goose <[email protected]> Co-authored-by: Douwe Osinga <[email protected]> Signed-off-by: esnyder <[email protected]>

* origin/main: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...

…pstream * wpfleger/socket-support: (62 commits) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) docs: add Claude Code approve mode permission routing documentation (#7949) chatgpt_codex: Support reasoning and gpt-5.4 (#7941) refactor(anthropic): fix N+1 thinking message storage issue (#7958) fix: handle mid-stream error events in OpenAI SSE streaming (#8031) Fix apps extension: coerce string arguments from inner LLM responses (#8030) feat: ability to expand sidebar to see chats names (#7816) Fix config for GOOSE_MAX_BACKGROUND_TASKS (#7940) set MACOSX_DEPLOYMENT_TARGET=12.0 (#7947) ...

* main: (37 commits) fix: handle reasoning content blocks in OpenAI-compat streaming parser (#8078) chore(acp): build native packages on latest mac (#8075) Display delegate sub agents logs in UI (#7519) Update tar version to avoid CVE-2026-33056 (#8073) refactor: consolidate duplicated dependencies into workspace (#8041) tui: set up for publishing via github actions (#8020) feat: feature-gate local inference dependencies (#7976) feat: ability to manage sub recipes in desktop ui (#6360) Tweak the release process: no more merge to main (#7994) fix: gemini models via databricks (#8042) feat(apps): Pass toolInfo to MCP Apps via hostContext (#7506) fix: remove configured marker when deleting oauth provider configuration (#7887) docs: add vmware-aiops MCP extension documentation (#8055) Show setup instructions for ACP providers in settings modal (#8065) deps: replace sigstore-verification with sigstore-verify to kill vulns (#8064) feat(acp): add session/set_config and stabilize list, delete and close (#7984) docs: Correct `gosoe` typo to `goose` (#8062) fix: use default provider and model when provider in session no longer exists (#8035) feat: add GOOSE_SHELL env var to configure preferred shell (#7909) fix(desktop): fullscreen header bar + always-visible close controls (#8033) ...

aharvard and others added 4 commits March 20, 2026 10:11

aharvard marked this pull request as ready for review March 20, 2026 14:32

aharvard mentioned this pull request Mar 20, 2026

MCP Apps: Spec compliance tracking (2026-01-26) #8017

Open

25 tasks

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

ui/desktop/src/components/McpApps/McpAppRenderer.tsx Outdated Show resolved Hide resolved

ui/desktop/src/components/McpApps/McpAppRenderer.tsx Show resolved Hide resolved

Douwe Osinga added 2 commits March 20, 2026 10:49

Merge remote-tracking branch 'origin/main' into fix/fullscreen-close-…

ca61020

…button-always-visible

remove debug console.log statements

f9c47d1

Signed-off-by: Douwe Osinga <[email protected]>

DOsinga approved these changes Mar 20, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

ui/desktop/src/components/McpApps/McpAppRenderer.tsx Show resolved Hide resolved

aharvard enabled auto-merge March 20, 2026 15:04

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

ui/desktop/src/components/McpApps/useDisplayMode.ts Outdated Show resolved Hide resolved

ui/desktop/src/components/McpApps/McpAppRenderer.tsx Outdated Show resolved Hide resolved

aharvard disabled auto-merge March 20, 2026 15:12

aharvard and others added 2 commits March 20, 2026 11:24

aharvard enabled auto-merge March 20, 2026 15:29

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

ui/desktop/src/components/McpApps/useDisplayMode.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

ui/desktop/src/components/McpApps/useDisplayMode.ts Show resolved Hide resolved

fix: add isFullscreen to useMemo dependency array

33204b0

Signed-off-by: Andrew Harvard <[email protected]> Co-authored-by: Goose <[email protected]> Ai-assisted: true

aharvard added this pull request to the merge queue Mar 20, 2026

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/goose-mcp/src/autovisualiser/templates/assets/mcp-app-bridge.js Show resolved Hide resolved

Merged via the queue into main with commit 80f3e50 Mar 20, 2026
21 checks passed

aharvard deleted the fix/fullscreen-close-button-always-visible branch March 20, 2026 16:21

github-actions bot mentioned this pull request Mar 24, 2026

chore(release): release version 1.29.0 #8089

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(desktop): fullscreen header bar + always-visible close controls#8033

fix(desktop): fullscreen header bar + always-visible close controls#8033
aharvard merged 12 commits intomainfrom
fix/fullscreen-close-button-always-visible

aharvard commented Mar 20, 2026 •

edited

Loading

Uh oh!

aharvard commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

DOsinga left a comment

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aharvard commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

useDisplayMode.ts

McpAppRenderer.tsx

Testing

Uh oh!

aharvard commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aharvard commented Mar 20, 2026 •

edited

Loading

`useDisplayMode.ts`

`McpAppRenderer.tsx`