fix: overwrite the deprecated googledrive extension config#7974
fix: overwrite the deprecated googledrive extension config#7974lifeizhou-ap merged 3 commits intomainfrom
Conversation
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
slightly worried about backwards compat and what this means here ... hrm...
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8267d17a7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const bundledExt of bundledExtensions) { | ||
| // Find if this extension already exists | ||
| const existingExt = existingExtensions.find((ext) => nameToKey(ext.name) === bundledExt.id); |
There was a problem hiding this comment.
The migration check is only reached for entries that match a bundledExt.id, but this loop iterates bundled-extensions.json, which currently has no googledrive/google_drive entry. In that case existingExt is never the deprecated Google Drive extension, so isDeprecatedGoogleDriveExtension(...) never triggers and the old bundled config is not overwritten. Users with deprecated Google Drive config will keep stale settings despite this fix.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
in the release version, the googledrive will be in the bundled-extensions.json
| await syncBundledExtensions(existingExtensions, addExtensionFn); | ||
|
|
||
| expect(addExtensionFn).toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
These tests only assert that addExtensionFn was called at least once, but syncBundledExtensions already calls addExtensionFn for other missing bundled defaults in the fixture. That means the test passes even when the deprecated googledrive entry is never detected or overwritten, so it does not protect the migration behavior this commit is adding.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
i have updated my tests based on your comment, but seems the ui has not refreshed
Hi @michaelneale Thanks for the review! The bundle sync did not work before this PR as a few users were stuck with the old google drive extension (type: built-in). So this PR is to enable the update google drive extension on their Desktop from the bundled extension. Also I found the The reason i have included this is that some users in windows have error of |
* main: (22 commits) feat: add gemini-acp provider, update docs on subscription models + improvements to codex (#8000) fix(openai): use Responses API for gpt-5.4 (#7982) Remove lead/worker provider (#7989) chore(release): release version 1.28.0 (#7991) Fix empty tool results from resource content (e.g. auto visualiser) (#7866) Separate SSE streaming from POST work submission (#7834) fix: include token usage in Databricks streaming responses (#7959) Optimize tool summarization (#7938) fix: overwrite the deprecated googledrive extension config (#7974) refactor: remove unnecessary Arc<Mutex> from tool execution pipeline (#7979) Revert message flush & test (#7966) docs: add Remote Access section with Telegram Gateway documentation (#7955) fix: update webmcp blog post metadata image URL (#7967) fix: clean up OAuth token cache on provider deletion (#7908) fix: hard-coded tool call id in code mode callback (#7939) Fix SSE parsers to accept optional space after data: prefix (#7929) docs: add GOOSE_INPUT_LIMIT to config-files.md (#7961) Add WebMCP for Beginners blog post (#7957) Fix download manager (#7933) Improve the formatting of tool calls, show thinking, treat Reasoning and Thinking as the same thing (sorry Kant) (#7626) ...
Signed-off-by: esnyder <[email protected]>
Signed-off-by: esnyder <[email protected]>
2 participants
Summary
Why
Old
builtingoogledrive extension config cannot be synced with the newstdioconfig in DesktopWhat
bundledbut deprecated, update it.Testing
Manual testing